Review 12.4 Merged

83459[TASK] Add meaningful title to File selector add file button

Oli Bartsch CR +2 V +2 Easy +14 −4 updated 03/13/24, 18:33

Commit message

The "+" labelled button in the File selector modal was just
labelled with the filename as the title which doesn't give
any meaning to screenreader users.

To show the purpose of the button to screenreader users the
title has been changed to additionally describe the action.

Also an aria-label with the same value has been added. This
is not ideal, because some screenreaders will read out the
title twice, but on the other hand other screenreaders ignore
the title or the aria-label attribute.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch uploaded patch set 1 03/13/24, 18:28

  2. core-ci voted on patch set 1 V +1 03/13/24, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54501

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 03/13/24, 18:33

  4. Oli Bartsch merged patch set 2 03/13/24, 18:33