Review main Merged

83462[TASK] Deprecate `GeneralUtility::hmac()`

Torben Hansen CR +2 V +2 Normal +146 −30 updated 03/21/24, 22:00

Commit message

In order to ensure unique HMACs in TYPO3, all usages of
`TYPO3\CMS\Core\Utility\GeneralUtility::hmac` have been
replaced with the `hmac` function in
`\TYPO3\CMS\Core\Crypto\HashService`.

This change finally deprecates `GeneralUtility::hmac()`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1520

  1. Torben Hansen uploaded patch set 1 03/14/24, 08:52

  2. core-ci voted on patch set 1 V +1 03/14/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54520

  3. Mathias Brodala commented on patch set 1 03/14/24, 09:40

    Deprecation-102762-DeprecateGeneralUtilityhmac.rst:54

    Since people tend to copy-and-paste, this should be the "After" snippet shown here, there are examples in other changelog files.
  4. Oliver Klee commented on patch set 1 03/14/24, 09:51

    GeneralUtility.php:474

    This method also should get an annotation: `@deprecated since TYPO3 13.1, will be removed in TYPO3 V14`
  5. Stefan Bürk commented on patch set 1 CR -1 03/14/24, 10:59

    on it ...
  6. Stefan Bürk uploaded patch set 2 CR -1 V +1 03/14/24, 11:15

  7. Stefan Bürk updated the commit message in patch set 3 03/14/24, 11:15

  8. Stefan Bürk commented on patch set 3 CR +1 V +1 03/14/24, 11:15

    GeneralUtility.php:474 Reply

    Done

    Deprecation-102762-DeprecateGeneralUtilityhmac.rst:54 Reply

    Done
  9. core-ci voted on patch set 2 V +1 03/14/24, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54530

  10. core-ci voted on patch set 3 V +1 03/14/24, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54531

  11. Oliver Klee voted on patch set 3 CR +1 V +1 03/14/24, 11:29

  12. Benni Mack commented on patch set 3 CR -1 03/14/24, 12:58

    on it
  13. Torben Hansen uploaded patch set 4 CR +1 V +1 03/21/24, 18:01

  14. core-ci voted on patch set 4 V +1 03/21/24, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54813

  15. Benni Mack commented on patch set 5 V +1 03/21/24, 19:29

    Published edit on patch set 4.
  16. Benni Mack voted on patch set 5 CR +1 V +1 03/21/24, 19:29

  17. core-ci voted on patch set 5 V +1 03/21/24, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54815

  18. Oliver Klee voted on patch set 5 CR +1 V +1 03/21/24, 21:25

  19. Benni Mack voted on patch set 5 CR +2 V +2 03/21/24, 22:00

  20. Benni Mack merged patch set 6 03/21/24, 22:00