83462[TASK] Deprecate `GeneralUtility::hmac()`
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Utility/GeneralUtility.php2+5 −0
- typo3/sysext/core/Documentation/Changelog/13.1/Deprecation-102762-GeneralUtilityhmac.rstnew+81 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+0 −30
- typo3/sysext/core/Tests/UnitDeprecated/Utility/GeneralUtilityTest.phpnew+53 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 1520
-
Torben Hansen uploaded patch set 1 03/14/24, 08:52
-
core-ci voted on patch set 1 V +1 03/14/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54520
-
Mathias Brodala commented on patch set 1 03/14/24, 09:40
-
Oliver Klee commented on patch set 1 03/14/24, 09:51
GeneralUtility.php:474This method also should get an annotation: `@deprecated since TYPO3 13.1, will be removed in TYPO3 V14` -
Stefan Bürk commented on patch set 1 CR -1 03/14/24, 10:59
on it ... -
Stefan Bürk uploaded patch set 2
CR -1V +103/14/24, 11:15 -
Stefan Bürk updated the commit message in patch set 3 03/14/24, 11:15
-
Stefan Bürk commented on patch set 3 CR +1 V +1 03/14/24, 11:15
GeneralUtility.php:474ReplyDoneDeprecation-102762-DeprecateGeneralUtilityhmac.rst:54ReplyDone -
core-ci voted on patch set 2 V +1 03/14/24, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54530
-
core-ci voted on patch set 3 V +1 03/14/24, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54531
-
Oliver Klee voted on patch set 3 CR +1 V +1 03/14/24, 11:29
-
Benni Mack commented on patch set 3 CR -1 03/14/24, 12:58
on it -
Torben Hansen uploaded patch set 4
CR +1V +103/21/24, 18:01 -
core-ci voted on patch set 4 V +1 03/21/24, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54813
-
Benni Mack commented on patch set 5
V +103/21/24, 19:29Published edit on patch set 4. -
Benni Mack voted on patch set 5 CR +1 V +1 03/21/24, 19:29
-
core-ci voted on patch set 5 V +1 03/21/24, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54815
-
Oliver Klee voted on patch set 5 CR +1 V +1 03/21/24, 21:25
-
Benni Mack voted on patch set 5 CR +2 V +2 03/21/24, 22:00
-
Benni Mack merged patch set 6 03/21/24, 22:00
Deprecation-102762-DeprecateGeneralUtilityhmac.rst:54