Review main Merged

83463[TASK] Apply stricter URI route generation assertions

Oliver Hader CR +2 V +2 Normal +24 −150 updated 03/15/24, 09:09

Commit message

Several tests for URI route generation are stricter and assert
that either the whole URI matches, or that at least the `?cHash=`
suffix is applied for the corresponding test permutations.

Besides that, individual URI assertions are streamlined to use
AbstractEnhancerLinkGeneratorTestCase::assertGeneratedUriEquals.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1012

  1. Oliver Hader uploaded patch set 1 03/14/24, 10:35

  2. core-ci voted on patch set 1 V +1 03/14/24, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54522

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 03/14/24, 10:55

  4. Oliver Hader marked it work in progress 03/14/24, 11:16

  5. Oliver Hader commented on patch set 1 03/14/24, 11:17

    It's seems, some more assertions can be simplified...
  6. Oliver Hader uploaded patch set 2 CR +1 V +1 03/14/24, 11:42

  7. Oliver Hader marked it ready for review 03/14/24, 11:43

  8. core-ci voted on patch set 2 V +1 03/14/24, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54533

  9. Stefan Bürk voted on patch set 2 CR +1 V +1 03/14/24, 17:02

  10. Benni Mack voted on patch set 2 CR +1 V +1 03/15/24, 08:41

  11. Oliver Hader voted on patch set 2 CR +2 V +2 03/15/24, 09:00

  12. Oliver Hader merged patch set 3 03/15/24, 09:09