83463[TASK] Apply stricter URI route generation assertions
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/AbstractEnhancerLinkGeneratorTestCase.php+16 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/LocaleModifierTest.php+1 −31
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/PersistedAliasMapperTest.php+1 −27
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/PersistedPatternMapperTest.php+1 −30
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/RouteTest.php+3 −3
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/StaticRangeMapperTest.php+1 −27
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/StaticValueMapperTest.php+1 −30
Review log 1012
-
Oliver Hader uploaded patch set 1 03/14/24, 10:35
-
core-ci voted on patch set 1 V +1 03/14/24, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54522
-
Stefan Bürk voted on patch set 1 CR +1 V +1 03/14/24, 10:55
-
Oliver Hader marked it work in progress 03/14/24, 11:16
-
Oliver Hader commented on patch set 1 03/14/24, 11:17
It's seems, some more assertions can be simplified... -
Oliver Hader uploaded patch set 2
CR +1V +103/14/24, 11:42 -
Oliver Hader marked it ready for review 03/14/24, 11:43
-
core-ci voted on patch set 2 V +1 03/14/24, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54533
-
Stefan Bürk voted on patch set 2 CR +1 V +1 03/14/24, 17:02
-
Benni Mack voted on patch set 2 CR +1 V +1 03/15/24, 08:41
-
Oliver Hader voted on patch set 2 CR +2 V +2 03/15/24, 09:00
-
Oliver Hader merged patch set 3 03/15/24, 09:09