Review 11.5 Merged

83465[TASK] Apply stricter URI route generation assertions

Oliver Hader CR +2 V +2 Normal +24 −150 updated 03/15/24, 09:09

Commit message

Several tests for URI route generation are stricter and assert
that either the whole URI matches, or that at least the `?cHash=`
suffix is applied for the corresponding test permutations.

Besides that, individual URI assertions are streamlined to use
AbstractEnhancerLinkGeneratorTestCase::assertGeneratedUriEquals.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 57

  1. Oliver Hader uploaded patch set 1 03/14/24, 10:58

  2. core-ci voted on patch set 1 V +1 03/14/24, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54526

  3. Oliver Hader commented on patch set 1 CR -1 03/14/24, 11:43

    needs update
  4. Oliver Hader uploaded patch set 2 CR -1 V +1 03/14/24, 11:59

  5. core-ci voted on patch set 2 V +1 03/14/24, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54536

  6. Oliver Hader voted on patch set 2 CR +2 V +2 03/15/24, 09:09

  7. Oliver Hader merged patch set 3 03/15/24, 09:09