Review main Merged

83467[TASK] Set empty alt text for file reference thumbnails

Willi Wehmeier CR +2 V +2 Easy +1 −1 updated 03/14/24, 11:42

Commit message

The thumbnail images in the inline file relations have the properties
alt and title set to "id=x" which is only helpful when used to show the
record uid in the tooltip. For screenreader users the info in the alt
attribute isn't helpful at all.
That's why the alt text should be empty so the thumbnail doesn't get
read out by screenreaders at all.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Willi Wehmeier uploaded patch set 1 03/14/24, 11:12

  2. Willi Wehmeier updated the commit message in patch set 2 03/14/24, 11:13

  3. core-ci voted on patch set 1 V +1 03/14/24, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54528

  4. core-ci voted on patch set 2 V +1 03/14/24, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54529

  5. Andreas Kienast voted on patch set 2 CR +1 03/14/24, 11:23

  6. Jasmina Ließmann voted on patch set 2 CR +1 V +1 03/14/24, 11:35

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 03/14/24, 11:42

  8. Oli Bartsch merged patch set 3 03/14/24, 11:42