Review main Merged

83470[BUGFIX] Avoid mapping route values that are out of scope

Oliver Hader CR +2 V +2 Normal +113 −6 updated 04/23/24, 11:10

Commit message

Given a static route argument mapper is used - for instance one
that allows values in the range of 1 to 100 - then generating an
URL from a route with an out of scope `&value=5000` was still
generating an URL. However, HTTP request to that URL would
result in an 404 error.

This change skips routes using out of scope values during the
URL generation process to avoid pointing to invalid resources.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Markus Klein +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1012

  1. Oliver Hader uploaded patch set 1 03/14/24, 17:48

  2. core-ci voted on patch set 1 V +1 03/14/24, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54550

  3. Oliver Hader updated the commit message in patch set 2 V +1 03/14/24, 18:01

  4. core-ci voted on patch set 2 V +1 03/14/24, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54551

  5. Andreas Kienast commented on patch set 2 03/15/24, 09:35

    VariableValue.php:136

    nitpick: can be written as `self::wrap(...)`.
  6. Oliver Hader commented on patch set 2 03/15/24, 10:43

    VariableValue.php:136 Reply

    ACK & known. For simplified back-porting, adjusting the callback notation was postponed...
  7. Benni Mack voted on patch set 2 CR +1 V +1 04/04/24, 16:07

  8. Stefan Bürk voted on patch set 2 CR +1 V +1 04/05/24, 00:48

  9. Markus Klein voted on patch set 2 CR +1 V +1 04/05/24, 10:46

  10. Oliver Klee voted on patch set 2 V +1 04/05/24, 11:56

  11. Oliver Hader voted on patch set 2 CR +2 V +2 04/23/24, 11:10

  12. Oliver Hader merged patch set 3 04/23/24, 11:10