Review main Merged

83471[BUGFIX] Bail out if `AbstractExceptionHandler` cannot write logs

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 03/15/24, 08:48

Commit message

If an exception cannot get written into the database, e.g. due to
connectivity issues, exceptions are already caught. However, this
doesn't work on low-level errors that may arise if e.g. the DI container
is defunct, required by `ConnectionPool` internals.

The exception handling is changed to cover all `\Throwable`s.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christoph Lehmann +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Kienast uploaded patch set 1 03/15/24, 08:26

  2. core-ci voted on patch set 1 V +1 03/15/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54568

  3. Christoph Lehmann voted on patch set 1 CR +1 03/15/24, 08:34

  4. Benjamin Franzke voted on patch set 1 CR +1 V +1 03/15/24, 08:35

  5. Oliver Hader voted on patch set 1 CR +1 V +1 03/15/24, 08:35

  6. Andreas Kienast voted on patch set 1 CR +2 V +2 03/15/24, 08:48

  7. Andreas Kienast merged patch set 2 03/15/24, 08:48