Review main Merged

83494[BUGFIX] Use correct icon for pages table

Georg Ringer CR +2 V +2 Easy +2 −1 updated 04/08/24, 06:53

Commit message

The check for content_from_pid is wrong as it is not the raw database record and therefore the relation is an array.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1922

  1. Georg Ringer uploaded patch set 1 03/15/24, 14:08

  2. Georg Ringer commented on patch set 1 03/15/24, 14:08

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 03/15/24, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54593

  4. Andreas Kienast commented on patch set 1 03/15/24, 14:20

    IconFactory.php:215

    Why is `$row['content_from_pid']` an array in the first place? This looks like another bug that rather should be solved.
  5. Andreas Kienast commented on patch set 1 03/15/24, 14:41

    IconFactory.php:215 Reply

    I've debugged this now. `pages.content_from_pid` is defined in TCA as a `group` field. FormEngine's `FormDataProvider\TcaGroup` converts the value to an array then.
  6. Andreas Kienast commented on patch set 1 03/15/24, 15:12

    I've pushed an alternative approach at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83495. Let's wait for feedback from lolli.
  7. Georg Ringer rebased onto patch set 2 V +1 03/19/24, 15:18

  8. Georg Ringer commented on patch set 2 03/19/24, 15:18

    Reply

    looks better to me
  9. core-ci voted on patch set 2 V +1 03/19/24, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54701

  10. Riccardo De Contardi commented on patch set 2 V +1 03/30/24, 10:13

    tested on latest main; edit page with the following doktypes: home, standard , shortcut, sysfolder, external url, mount point,separator (also with attributes: not in menu, hidden, extend to subpages,starttime, endtime,content_from_pid)
  11. Jörg Bösche voted on patch set 2 CR +1 04/04/24, 06:32

  12. Andreas Kienast commented on patch set 2 CR -1 04/04/24, 07:22

    -1 for now until a final decision is made about the proposed alternative. My main concern is that FormEngine internals are now introduced to the IconFactory.
  13. Christian Kuhn commented on patch set 2 04/07/24, 07:49

    Reply

    Well. IconFactory->mapRecordTypeToIconIdentifier() is pretty much tailored for FormEngine only, and already contains similar code that deals with arrays. As such, I'd go this way and eventually resolved the method `@todo` at some point by modeling the method as part of FormEngine.
  14. Andreas Kienast voted on patch set 2 CR 0 04/07/24, 10:59

  15. Christian Kuhn commented on patch set 2 04/07/24, 11:20

    IconFactory.php:215 Reply

    Done
  16. Georg Ringer rebased onto patch set 3 CR +1 V +1 04/07/24, 11:20

  17. Christian Kuhn voted on patch set 3 CR +1 V +1 04/07/24, 11:21

  18. core-ci voted on patch set 3 V +1 04/07/24, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55504

  19. Andreas Kienast voted on patch set 3 CR +1 V +1 04/07/24, 15:19

  20. Stefan Bürk voted on patch set 3 CR +1 V +1 04/07/24, 16:12

  21. Christian Kuhn voted on patch set 3 CR +2 V +2 04/08/24, 06:53

  22. Christian Kuhn merged patch set 4 04/08/24, 06:53