Review main Merged

83497[BUGFIX] Prevent null pointer exception in ContentObjectRenderer

Oli Bartsch CR +2 V +2 Easy +3 −3 updated 03/18/24, 07:42

Commit message

The $request might not be initialized, that's
why the getRequest() method has to be used in
ContentObjectRenderer.

This is now done for newly introduced occurrences,
accessing the class property directly.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Oli Bartsch uploaded patch set 1 03/15/24, 17:08

  2. core-ci voted on patch set 1 V +1 03/15/24, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54602

  3. Oliver Klee voted on patch set 1 CR +1 03/15/24, 18:11

  4. Oliver Klee commented on patch set 1 03/15/24, 18:12

    V12 is not affected?
  5. Oli Bartsch commented on patch set 1 03/15/24, 20:11

    Reply

    no
  6. Oliver Klee commented on patch set 1 03/15/24, 22:55

    Reply

    Ack.
  7. Benni Mack voted on patch set 1 CR +1 03/16/24, 09:02

  8. Stefan Bürk voted on patch set 1 CR +1 V +1 03/16/24, 09:10

  9. Benjamin Franzke voted on patch set 1 CR +2 V +2 03/18/24, 07:42

  10. Benjamin Franzke merged patch set 2 03/18/24, 07:42