Review main Merged

83501[TASK] Add title and aria-label to clear input button

Willi Wehmeier CR +2 V +2 Normal +45 −7 updated 05/02/24, 10:33

Commit message

The clear-input button now has a proper title and additionally an
aria-label to guide visually impaired users.

The button isn't read out by screenreaders when navigating the site
linearly (due to tabindex="-1") but when hold-pressing the button with
the mouse pointer, a screenreader will search for a human readable
label. We therefore add an aria-label attribute. The title attribute is
added for sighted users but will be ignored by screenreaders since it's
value equals the value of the aria-label attribute.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Frank Nägler +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Frank Nägler +1
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1519

  1. Willi Wehmeier uploaded patch set 1 03/18/24, 12:32

  2. core-ci voted on patch set 1 V +1 03/18/24, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54656

  3. Benjamin Franzke voted on patch set 1 CR +1 03/18/24, 12:48

  4. Jasmina Ließmann voted on patch set 1 CR +1 V +1 03/18/24, 13:32

  5. Benjamin Franzke commented on patch set 1 V -1 03/18/24, 14:54

    NVDA now reads input-field description when actively click-and-holding the X-Button. => Degration in terms of false reporting what the action of the click will do. (it reports selection of the input field, while it will actually delete)
  6. Jasmina Ließmann voted on patch set 1 V 0 03/18/24, 21:25

  7. Jasmina Ließmann commented on patch set 1 03/18/24, 21:25

    Reply

    Good point. I withdraw my positive verified vote.
  8. Frank Nägler commented on patch set 1 04/30/24, 06:16

    Thx to Benjamin Franzke, I found that patch and abandoned my patch here https://review.typo3.org/c/Packages/TYPO3.CMS/+/84086 Please let us finish this patch and get them in.
  9. Willi Wehmeier uploaded patch set 2 CR +1 V +1 04/30/24, 11:29

  10. core-ci voted on patch set 2 V +1 04/30/24, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57013

  11. Benjamin Franzke voted on patch set 2 CR +1 04/30/24, 11:39

  12. Benjamin Franzke updated the commit message in patch set 3 CR +1 V +1 05/01/24, 07:15

  13. Benjamin Franzke updated the commit message in patch set 4 CR +1 V +1 05/01/24, 07:16

  14. core-ci voted on patch set 3 V +1 05/01/24, 07:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57044

  15. core-ci voted on patch set 4 V +1 05/01/24, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57045

  16. Michael Telgkamp voted on patch set 4 CR +1 V +1 05/02/24, 09:36

  17. Frank Nägler voted on patch set 4 CR +1 V +1 05/02/24, 10:05

  18. Benjamin Franzke voted on patch set 4 CR +2 V +2 05/02/24, 10:23

  19. Benjamin Franzke merged patch set 5 05/02/24, 10:33