83501[TASK] Add title and aria-label to clear input button
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Frank Nägler +1
- Michael Telgkamp +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Frank Nägler +1
- Michael Telgkamp +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/backend/input/clearable.ts+12 −2
- Build/Sources/TypeScript/install/renderable/clearable.ts+12 −2
- typo3/sysext/backend/Resources/Private/Templates/Login/ForgetPasswordForm.html+12 −1
- typo3/sysext/backend/Resources/Private/Templates/Login/ResetPasswordForm.html+2 −0
- typo3/sysext/backend/Resources/Private/Templates/Login/UserPassLoginForm.html+2 −0
- typo3/sysext/backend/Resources/Public/JavaScript/input/clearable.js+1 −1
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+3 −0
- typo3/sysext/install/Resources/Public/JavaScript/renderable/clearable.js+1 −1
Review log 1519
-
Willi Wehmeier uploaded patch set 1 03/18/24, 12:32
-
core-ci voted on patch set 1 V +1 03/18/24, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54656
-
Benjamin Franzke voted on patch set 1 CR +1 03/18/24, 12:48
-
Jasmina Ließmann voted on patch set 1 CR +1 V +1 03/18/24, 13:32
-
Benjamin Franzke commented on patch set 1 V -1 03/18/24, 14:54
NVDA now reads input-field description when actively click-and-holding the X-Button. => Degration in terms of false reporting what the action of the click will do. (it reports selection of the input field, while it will actually delete) -
Jasmina Ließmann voted on patch set 1 V 0 03/18/24, 21:25
-
Jasmina Ließmann commented on patch set 1 03/18/24, 21:25
Reply
Good point. I withdraw my positive verified vote. -
Frank Nägler commented on patch set 1 04/30/24, 06:16
Thx to Benjamin Franzke, I found that patch and abandoned my patch here https://review.typo3.org/c/Packages/TYPO3.CMS/+/84086 Please let us finish this patch and get them in. -
Willi Wehmeier uploaded patch set 2
CR +1V +104/30/24, 11:29 -
core-ci voted on patch set 2 V +1 04/30/24, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57013
-
Benjamin Franzke voted on patch set 2 CR +1 04/30/24, 11:39
-
Benjamin Franzke updated the commit message in patch set 3
CR +1V +105/01/24, 07:15 -
Benjamin Franzke updated the commit message in patch set 4
CR +1V +105/01/24, 07:16 -
core-ci voted on patch set 3 V +1 05/01/24, 07:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57044
-
core-ci voted on patch set 4 V +1 05/01/24, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57045
-
Michael Telgkamp voted on patch set 4 CR +1 V +1 05/02/24, 09:36
-
Frank Nägler voted on patch set 4 CR +1 V +1 05/02/24, 10:05
-
Benjamin Franzke voted on patch set 4 CR +2 V +2 05/02/24, 10:23
-
Benjamin Franzke merged patch set 5 05/02/24, 10:33