Review 11.5 Merged

83514[TASK] Apply some runTests.sh cleanups

Benjamin Franzke CR +2 V +2 Easy +38 −12 updated 03/19/24, 13:16

Commit message

* Always clean-up containers when Control-C is pressed
 * Enforce removing networks even if some containers have not been
   fully stopped (does not work with older docker versions, therefore
   only enabled for podman)
 * Bail out if `waitFor` failed instead of resuming with subsequent
   commands
 * Avoid waiting unnecessarily for VNC-web port 7900 in headless mode
 * Do not derive `--pull=never` from the `$CI` environment variable, as
   `$CI` is set both in gitlab [1] and github [2] actions.
   runTests.sh might be used in github actions, therefore this flag is
   moved into our gitlab-ci specific configuration.
 * Fix broken `-b podman -s acceptance -d sqlite` UID mapping and sqlite
   mount
   Error was: `unknown mount option "uid=1000": invalid mount option`
   The sqlite tmpfs is removed, as the sqlite tmpfs can not be shared
   between the PHP development server and codecept (which bootstraps
   the database in `bin/codecept` in classic-mode)
 * Avoid `--add-host` for podman for compat with github ubuntu-latest
   podman version
 * Fix typos

[1] https://docs.gitlab.com/ee/ci/variables/predefined_variables.html
[2] https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 48

  1. Benjamin Franzke uploaded patch set 1 03/19/24, 08:41

  2. core-ci voted on patch set 1 V -1 03/19/24, 08:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54677

  3. core-ci voted on patch set 1 V +1 03/19/24, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54677

  4. Benjamin Franzke uploaded patch set 2 V +1 03/19/24, 10:51

  5. core-ci voted on patch set 2 V -1 03/19/24, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54686

  6. core-ci voted on patch set 2 V +1 03/19/24, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54686

  7. Benjamin Franzke voted on patch set 2 CR +2 V +2 03/19/24, 13:16

  8. Benjamin Franzke merged patch set 3 03/19/24, 13:16