83515[TASK] Apply some runTests.sh cleanups
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 810
-
Benjamin Franzke uploaded patch set 1 03/19/24, 09:05
-
core-ci voted on patch set 1 V +1 03/19/24, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54678
-
Benjamin Franzke uploaded patch set 2
V +103/19/24, 10:48 -
core-ci voted on patch set 2 V +1 03/19/24, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54684
-
Christian Kuhn voted on patch set 2 CR +1 V +1 03/19/24, 11:09
-
Christian Kuhn commented on patch set 2 03/19/24, 11:45
-
Benjamin Franzke commented on patch set 2 03/19/24, 13:08
runTests.sh:7Replyyup, @a.fernandez@scripting-base.de tested this on macos with bash v3.2: Changing port in waitFor from `4444` to `4445` successfully aborted the script and returned the configured exit code in trap: ``` ❯ Build/Scripts/runTests.sh -b docker -s acceptance Can not connect to chrome port 4445. Aborting. ❯ echo "EXIT code was: $?" EXIT code was: 2 ``` -
Stefan Bürk voted on patch set 2 CR +1 V +1 03/19/24, 13:13
-
Benjamin Franzke voted on patch set 2 CR +2 V +2 03/19/24, 13:16
-
Benjamin Franzke merged patch set 3 03/19/24, 13:16
runTests.sh:7