83525[BUGFIX] Avoid array access warning in TSFE INT handling
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1417
-
Georg Ringer uploaded patch set 1 03/19/24, 15:18
-
Georg Ringer commented on patch set 1 03/19/24, 15:18
This change is ready for review. -
core-ci voted on patch set 1 V +1 03/19/24, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54702
-
Christian Kuhn commented on patch set 1 03/19/24, 15:29
notice? -
Oliver Klee commented on patch set 1 03/19/24, 15:29
If the notice also can occur in 11.5, I'd propose to add this to the target releases.TypoScriptFrontendController.php:603Maybe we can put this in a local variable to reduce the code duplication. -
Garvin Hicking commented on patch set 1 03/19/24, 18:50
Reply
See ticket; I wonder though if some underlying issue could prevent the divKey arrays from being set? Just ??:'' them might just fix the symptom but not the cause? (Maybe checking for that divkey being set could prevent all of the str_replace, that would save some operations/grepping?) -
Stefan Bürk commented on patch set 1 03/22/24, 08:41
It does not make sense to silcence the notice with a guard here. If divKey is empty it does not make sense to handle the INT replacement at all. I'd say the root casue should be investaged why divKey is not set in the first place as this is the bug and not the missing guard here. At least, if divKey is empty the work should be omitted (replace) - or am I wrong here ? I guess this needs a little bit deeper investigation than a simply quick guard fix. -
Oliver Klee wrote 08/25/24, 10:11
Removed cc Oliver Klee. -
Christian Kuhn commented on patch set 1 09/19/24, 22:32
TypoScriptFrontendController.php:603Replylet's keep it simple as is. -
Christian Kuhn commented on patch set 1 09/19/24, 22:34
Reply
i think its fine to fix the warning for now. this is a clear bug and it's better to go with a straight fix in this case. the INT handling needs an overhaul anyways and will see it in v14.Reply
will rephrase. i think we should fix the issue and refactor INT handling in v14 (i'm planing for that already). -
Georg Ringer rebased onto patch set 2
V +109/19/24, 22:34 -
Christian Kuhn updated the commit message in patch set 3 09/19/24, 22:35
-
Christian Kuhn voted on patch set 3 CR +1 V +1 09/19/24, 22:35
-
core-ci voted on patch set 2 V +1 09/19/24, 22:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66264
-
core-ci voted on patch set 3 V +1 09/19/24, 22:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66265
-
Stefan Bürk voted on patch set 3 CR +2 V +2 09/20/24, 09:47
-
Stefan Bürk merged patch set 4 09/20/24, 09:57