Review main Merged

83553[BUGFIX] Inject logger into YamlFileLoader

Benjamin Franzke CR +2 V +2 Easy +6 −6 updated 03/21/24, 11:20

Commit message

YamlFileLoader needs to be instantiated via `self::new` to
ensure that a logger instance is injected.

The issues was introduced with #103187 where YamlFileLoader was added to
be provided by the EXT:install ServiceProvider. This is actually not
quite right, as a service is always to be provided by the extension that
ships the service, not by the consumer.

Therefore the YamlFileLoader service definition is now moved into
EXT:core.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Benjamin Franzke uploaded patch set 1 03/21/24, 04:35

  2. core-ci voted on patch set 1 V +1 03/21/24, 04:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54763

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 03/21/24, 06:59

  4. Oli Bartsch voted on patch set 1 CR +1 V +1 03/21/24, 11:04

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 03/21/24, 11:20

  6. Benjamin Franzke merged patch set 2 03/21/24, 11:20