Review main Merged

83554[TASK] Do not render `typo3-formengine-updater` if linked field is hidden

Andreas Kienast CR +2 V +2 Easy +13 −12 updated 03/21/24, 10:45

Commit message

TYPO3's TCA type field is rendered in the FormEngine along with a
`<typo3-formengine-updater>` element that listens on changes on the
linked type field.

This is a rare case: if FormEngine is programmatically rendered via an
own controller and the value of the `type` field is hardcoded via
`overrideValues` in the FormEngine compiler, the field itself is not rendered.

However, the `<typo3-formengine-updater>` element is still there,
leaving an "empty" field group.

This patch now checks whether something is available for rendering
before rendering the `<typo3-formengine-updater>` element.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. Andreas Kienast uploaded patch set 1 03/21/24, 08:51

  2. Andreas Kienast uploaded patch set 2 03/21/24, 08:54

  3. core-ci voted on patch set 1 V +1 03/21/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54774

  4. core-ci voted on patch set 2 V +1 03/21/24, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54776

  5. Benjamin Franzke voted on patch set 2 CR +1 03/21/24, 09:05

  6. Andreas Kienast updated the commit message in patch set 3 CR +1 V +1 03/21/24, 09:14

  7. Benjamin Franzke updated the commit message in patch set 4 03/21/24, 09:19

  8. Benjamin Franzke voted on patch set 4 CR +1 V +1 03/21/24, 09:19

  9. core-ci voted on patch set 3 V +1 03/21/24, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54777

  10. core-ci voted on patch set 4 V +1 03/21/24, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54778

  11. Oli Bartsch voted on patch set 4 CR +2 V +2 03/21/24, 10:45

  12. Oli Bartsch merged patch set 5 03/21/24, 10:45