Review main Merged

83556[FEATURE] Add MySQL default value support for TEXT, JSON and BLOB

Stefan Bürk CR +2 V +2 Hard +505 −1 updated 04/10/24, 17:03

Commit message

Database default value configuration for TEXT, BLOB and
JSON field types has been impossible to use in a cross
database vendor manner due to lacking support from MySQL.

Direct default values are still unsupported, but
since `MySQL 8.0.13+` [1] it is possible to use a default
value expression with a slightly different syntax.

TYPO3 v13.0 already raised the minimal requirement to MySQL
8.0.17 paving the way to provide a compatible way to
define default values on database level now.

To align the TYPO3 Database Analyzer stack ...

* the extended `MySQLSchemaManager` is modified to revert
  default value expression to concrete values to make them
  comparable.

* default value expression are created for these field types
  by modifing the extended Doctrine MySQL platform classes
  using the `MySQLDefaultValueDeclarationSQLOverrideTrait`.

This change now adds support for database level default
values for TEXT, JSON and BLOB fields and is accompanied
by additional tests.

NOTE: This unblocks TCA type=input default schema management.

[1] https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-13.html#mysqld-8-0-13-data-types

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 1834

Show 59 earlier messages
  1. Stefan Bürk uploaded patch set 1 03/21/24, 11:35

  2. core-ci voted on patch set 1 V -1 03/21/24, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54783

  3. Stefan Bürk uploaded patch set 2 V -1 03/21/24, 11:43

  4. core-ci voted on patch set 2 V +1 03/21/24, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54784

  5. Stefan Bürk uploaded patch set 3 V +1 03/28/24, 11:29

  6. core-ci voted on patch set 3 V -1 03/28/24, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55021

  7. Stefan Bürk uploaded patch set 4 V -1 04/09/24, 09:28

  8. core-ci voted on patch set 4 V +1 04/09/24, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55594

  9. Stefan Bürk uploaded patch set 5 V +1 04/09/24, 09:39

  1. core-ci voted on patch set 5 V -1 04/09/24, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55595

  2. Stefan Bürk uploaded patch set 6 V -1 04/09/24, 11:54

  3. core-ci voted on patch set 6 V +1 04/09/24, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55603

  4. core-ci voted on patch set 6 V -1 04/09/24, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55605

  5. Stefan Bürk uploaded patch set 7 V -1 04/09/24, 15:04

  6. core-ci voted on patch set 7 V +1 04/09/24, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55610

  7. core-ci voted on patch set 7 V -1 04/09/24, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55611

  8. core-ci voted on patch set 7 V +1 04/09/24, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55611

  9. Stefan Bürk uploaded patch set 8 V +1 04/09/24, 16:26

  10. Stefan Bürk updated the commit message in patch set 9 04/09/24, 16:27

  11. core-ci voted on patch set 8 V +1 04/09/24, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55616

  12. core-ci voted on patch set 9 V +1 04/09/24, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55617

  13. Stefan Bürk uploaded patch set 10 V +1 04/09/24, 16:33

  14. core-ci voted on patch set 10 V +1 04/09/24, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55618

  15. Garvin Hicking uploaded patch set 11 V +1 04/09/24, 17:09

    RST changes
  16. core-ci voted on patch set 11 V +1 04/09/24, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55621

  17. Stefan Bürk uploaded patch set 12 V +1 04/10/24, 13:39

  18. Garvin Hicking commented on patch set 12 CR +1 V +1 04/10/24, 13:41

    Great! Tested that DEFAULT interpretation works in MySQL 8.0.33 and MariaDB 10.6.
  19. core-ci voted on patch set 12 V +1 04/10/24, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55684

  20. Stefan Bürk uploaded patch set 13 CR +1 V +1 04/10/24, 15:33

  21. core-ci voted on patch set 13 V +1 04/10/24, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55693

  22. Christian Kuhn voted on patch set 13 CR +1 V +1 04/10/24, 15:41

  23. Garvin Hicking voted on patch set 13 CR +1 V +1 04/10/24, 16:58

  24. Stefan Bürk voted on patch set 13 CR +2 V +2 04/10/24, 17:03

  25. Stefan Bürk merged patch set 14 04/10/24, 17:03