Review main Merged

83557[TASK] Extract site persistence into separate service

Benjamin Franzke CR +2 V +2 Hard +508 −356 updated 03/29/24, 09:47

Commit message

The SiteConfiguration service is currently needed during installation
phase for writing site configurations. This limits symfony dependency
injection usage and basically requires that all services needed by
SiteConfiguration need to be defined and manually wired in
ServiceProvider php code.

The writing part is now split into a separate service that can be used
in EXT:install SetupService as before.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jörg Bösche +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 1216

  1. Benjamin Franzke uploaded patch set 1 03/21/24, 12:44

  2. core-ci voted on patch set 1 V -1 03/21/24, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54789

  3. Benjamin Franzke uploaded patch set 2 V -1 03/21/24, 13:12

  4. core-ci voted on patch set 2 V +1 03/21/24, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54792

  5. Andreas Kienast voted on patch set 2 CR +1 03/21/24, 14:19

  6. Andreas Kienast commented on patch set 2 03/21/24, 15:07

    SiteWriter.php:30

    Unused

    SiteWriter.php:31

    Class doesn't exist. Perhaps an issue when extracting this from another patch in the relation chain?

    SiteWriter.php:62

    The next three properties are not used in this patch. I guess that's a rebase issue as well?
  7. Benjamin Franzke uploaded patch set 3 CR +1 V +1 03/21/24, 15:17

  8. Benjamin Franzke commented on patch set 3 03/21/24, 15:17

    SiteWriter.php:30 Reply

    Done, I wonder why `Build/Scripts/cglFixMyCommit.sh` did not remove them.

    SiteWriter.php:31 Reply

    Acknowledged

    SiteWriter.php:62 Reply

    oops, thanks!
  9. core-ci voted on patch set 3 V +1 03/21/24, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54810

  10. Andreas Kienast commented on patch set 3 03/21/24, 15:35

    SiteWriter.php:30 Reply

    Probably because `Site` is used somewhere in comments. phpcsfixer sometimes has issues to pick that up.
  11. Benjamin Franzke uploaded patch set 4 V +1 03/25/24, 09:18

  12. core-ci voted on patch set 4 V +1 03/25/24, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54916

  13. Jörg Bösche voted on patch set 4 CR +1 03/25/24, 11:49

  14. Benni Mack voted on patch set 4 CR +1 V +1 03/28/24, 19:40

  15. Georg Ringer voted on patch set 4 CR +2 V +2 03/29/24, 09:47

  16. Georg Ringer merged patch set 5 03/29/24, 09:47