83557[TASK] Extract site persistence into separate service
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Jörg Bösche +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 24
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+5 −4
- typo3/sysext/core/Classes/Configuration/Event/SiteConfigurationChangedEvent.phpnew+28 −0
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php+8 −186
- typo3/sysext/core/Classes/Configuration/SiteWriter.php7new+247 −0
- typo3/sysext/core/Classes/Hooks/CreateSiteConfiguration.php+3 −3
- typo3/sysext/core/Classes/ServiceProvider.php+3 −4
- typo3/sysext/core/Configuration/Services.yaml+0 −5
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedAliasMapperTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedPatternMapperTest.php+2 −2
- typo3/sysext/core/Tests/Functional/SiteHandling/SiteBasedTestTrait.php+5 −3
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+0 −109
- typo3/sysext/core/Tests/Unit/Configuration/SiteWriterTest.phpnew+164 −0
- typo3/sysext/impexp/Classes/Initialization/ImportSiteConfigurationsOnPackageInitialization.php+3 −1
- typo3/sysext/install/Classes/Service/SetupService.php+3 −3
- typo3/sysext/install/Classes/Updates/MigrateSiteSettingsConfigUpdate.php+4 −1
- typo3/sysext/install/Classes/ServiceProvider.php+2 −2
- typo3/sysext/install/Tests/Functional/Updates/MigrateSiteSettingsConfigUpdateTest.php+3 −4
- typo3/sysext/redirects/Tests/Functional/EventListener/AddPageTypeZeroSourceTest.php+3 −3
- typo3/sysext/redirects/Tests/Functional/EventListener/AddPlainSlugReplacementSourceTest.php+3 −3
- typo3/sysext/redirects/Tests/Functional/RedirectUpdate/SlugRedirectChangeItemFactoryTest.php+3 −4
Show 4 more files
Review log 1216
-
Benjamin Franzke uploaded patch set 1 03/21/24, 12:44
-
core-ci voted on patch set 1 V -1 03/21/24, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54789
-
Benjamin Franzke uploaded patch set 2
V -103/21/24, 13:12 -
core-ci voted on patch set 2 V +1 03/21/24, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54792
-
Andreas Kienast voted on patch set 2 CR +1 03/21/24, 14:19
-
Andreas Kienast commented on patch set 2 03/21/24, 15:07
SiteWriter.php:31Class doesn't exist. Perhaps an issue when extracting this from another patch in the relation chain?SiteWriter.php:62The next three properties are not used in this patch. I guess that's a rebase issue as well? -
Benjamin Franzke uploaded patch set 3
CR +1V +103/21/24, 15:17 -
Benjamin Franzke commented on patch set 3 03/21/24, 15:17
SiteWriter.php:30ReplyDone, I wonder why `Build/Scripts/cglFixMyCommit.sh` did not remove them.SiteWriter.php:31ReplyAcknowledgedSiteWriter.php:62Replyoops, thanks! -
core-ci voted on patch set 3 V +1 03/21/24, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54810
-
Andreas Kienast commented on patch set 3 03/21/24, 15:35
SiteWriter.php:30ReplyProbably because `Site` is used somewhere in comments. phpcsfixer sometimes has issues to pick that up. -
Benjamin Franzke uploaded patch set 4
V +103/25/24, 09:18 -
core-ci voted on patch set 4 V +1 03/25/24, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54916
-
Jörg Bösche voted on patch set 4 CR +1 03/25/24, 11:49
-
Benni Mack voted on patch set 4 CR +1 V +1 03/28/24, 19:40
-
Georg Ringer voted on patch set 4 CR +2 V +2 03/29/24, 09:47
-
Georg Ringer merged patch set 5 03/29/24, 09:47
SiteWriter.php:30