Review main Merged

83560[TASK] linkvalidator: Calculate option toggle state on render time

Andreas Kienast CR +2 V +2 Easy +12 −8 updated 04/03/24, 12:19

Commit message

This commit changes how the "Toggle all" and option and action button
states are determined. Previously, the state was determined via
JavaScript, leading to an unexpected rendering change when the module
has loaded.

To avoid this, the state is now calculated in the controller as the
necessary metrics are already known.

In the same run, `optionByType.checked` is now a simple bool flag
instead of holding arbitrary HTML attributes.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Jörg Bösche +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 913

  1. Andreas Kienast uploaded patch set 1 03/21/24, 13:36

  2. Andreas Kienast uploaded patch set 2 03/21/24, 13:41

  3. Andreas Kienast uploaded patch set 3 03/21/24, 13:42

  4. core-ci voted on patch set 1 V -1 03/21/24, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54797

  5. core-ci voted on patch set 3 V -1 03/21/24, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54799

  6. Andreas Kienast uploaded patch set 4 V -1 03/21/24, 13:45

  7. core-ci voted on patch set 4 V +1 03/21/24, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54800

  8. Benjamin Franzke uploaded patch set 5 V +1 03/21/24, 14:03

  9. core-ci voted on patch set 5 V +1 03/21/24, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54804

  10. Jörg Bösche voted on patch set 5 CR +1 03/25/24, 11:52

  11. Benni Mack voted on patch set 5 CR +1 V +1 04/03/24, 09:59

  12. Andreas Kienast voted on patch set 5 CR +2 V +2 04/03/24, 12:19

  13. Andreas Kienast merged patch set 6 04/03/24, 12:19