Review 12.4 Merged

83561[BUGFIX] Do not render empty `eval` and `is_in` instructions

Andreas Kienast CR +2 V +2 Normal +45 −23 updated 03/21/24, 14:38

Commit message

This commit checks whether `eval` and `is_in` are not empty before they
are used as "input params" for the JavaScript part of the FormEngine.

Also, a plausibility check is added to ensure `eval=is_in` and a
non-falsy `is_in` configuration are given.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Andreas Kienast uploaded patch set 1 03/21/24, 14:27

  2. core-ci voted on patch set 1 V +1 03/21/24, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54805

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 03/21/24, 14:38

  4. Andreas Kienast merged patch set 2 03/21/24, 14:38