Review main Merged

83565[TASK] Reduce overhead in BackendLayoutView

Benni Mack CR +2 V +2 Normal +18 −97 updated 03/22/24, 08:26

Commit message

BackendLayoutView is used to build the BackendLayout
structure, and does a few things too much:

a) it uses ArrayUtility over a simple isset() check for pageTsconfig
b) it resolves LLL labels directly, even if MoveContent wizard and Page module handle that as well
c) it re-builds logic only used in Move Content which is not needed due to a properly resolved colPos list already

All of this internal code can be removed and thus reduced to
a minimum, with Page module, FormEngine (pages+tt_content) and Move
Content Wizard continue to work, because FormEngine and all
other modules already use the proper API for rendering already.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Benni Mack uploaded patch set 1 03/21/24, 22:26

  2. core-ci voted on patch set 1 V -1 03/21/24, 22:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54820

  3. Benni Mack uploaded patch set 2 V -1 03/21/24, 22:45

  4. core-ci voted on patch set 2 V +1 03/21/24, 22:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54821

  5. Stefan Bürk voted on patch set 2 CR +1 03/22/24, 06:50

  6. Andreas Kienast voted on patch set 2 CR +1 V +1 03/22/24, 06:52

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 03/22/24, 07:45

  8. Oli Bartsch merged patch set 3 03/22/24, 07:45

  9. Stefan Bürk commented on patch set 3 V +1 03/22/24, 08:26

    post +1 verified ;)