Review main Merged

83567[TASK] Centralize Page Layout resolving

Benni Mack CR +2 V +2 Hard +299 −233 updated 03/23/24, 22:07

Commit message

This change centralizes Frontend's "PageLayoutResolver",
used in TypoScript, and BackendLayoutView logic
to find the used page layout, while also modelling
more towards an object within PageLayout which can be
used at a later stage in FE to retrieve more information.

At the same time, some BackendLayoutView code is reduced
now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1422

  1. Benni Mack uploaded patch set 1 03/22/24, 09:09

  2. core-ci voted on patch set 1 V -1 03/22/24, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54832

  3. Benni Mack uploaded patch set 2 V -1 03/22/24, 15:44

  4. core-ci voted on patch set 2 V -1 03/22/24, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54851

  5. Benni Mack rebased onto patch set 3 V -1 03/22/24, 16:09

  6. core-ci voted on patch set 3 V -1 03/22/24, 16:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54854

  7. Stefan Bürk uploaded patch set 4 V -1 03/22/24, 18:11

  8. core-ci voted on patch set 4 V -1 03/22/24, 18:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54858

  9. Stefan Bürk rebased onto patch set 5 V -1 03/22/24, 18:28

  10. core-ci voted on patch set 5 V -1 03/22/24, 18:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54860

  11. Benni Mack commented on patch set 5 CR -1 03/23/24, 20:19

    on it
  12. Stefan Bürk rebased onto patch set 6 CR -1 V -1 03/23/24, 20:23

  13. core-ci voted on patch set 6 V -1 03/23/24, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54893

  14. Benni Mack uploaded patch set 7 V -1 03/23/24, 20:51

  15. core-ci voted on patch set 7 V -1 03/23/24, 20:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54894

  16. Benni Mack uploaded patch set 8 V -1 03/23/24, 21:11

  17. core-ci voted on patch set 8 V +1 03/23/24, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54895

  18. Stefan Bürk voted on patch set 8 CR +1 03/23/24, 21:40

  19. Stefan Bürk voted on patch set 8 V +1 03/23/24, 21:42

  20. Nikita Hovratov commented on patch set 8 CR +1 V +1 03/23/24, 22:06

    Nice! It's good that we recently added a bunch of tests regarding pagelayout TypoScript conditions and the TypoScript getData function.
  21. Benni Mack commented on patch set 8 CR +2 V +2 03/23/24, 22:07

    Thanks, Nikita! more to come...
  22. Benni Mack merged patch set 9 03/23/24, 22:07