83567[TASK] Centralize Page Layout resolving
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+17 −51
- typo3/sysext/backend/Tests/Functional/View/BackendLayoutViewTest.php+3 −15
- typo3/sysext/core/Classes/Page/PageLayout.phpnew+49 −0
- typo3/sysext/core/Classes/Page/PageLayoutResolver.phpnew+134 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionMatcherVisitor.php+2 −2
- typo3/sysext/core/Configuration/Services.yaml+3 −0
- typo3/sysext/core/Tests/Functional/Page/PageLayoutResolverTest.phpnew+87 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+2 −2
- typo3/sysext/frontend/Classes/Page/PageLayoutResolver.phpdeleted+0 −73
- typo3/sysext/frontend/Tests/Unit/Page/PageLayoutResolverTest.phpdeleted+0 −87
- typo3/sysext/webhooks/Tests/Functional/WebhookExecutionTest.php+2 −3
Review log 1422
-
Benni Mack uploaded patch set 1 03/22/24, 09:09
-
core-ci voted on patch set 1 V -1 03/22/24, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54832
-
Benni Mack uploaded patch set 2
V -103/22/24, 15:44 -
core-ci voted on patch set 2 V -1 03/22/24, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54851
-
Benni Mack rebased onto patch set 3
V -103/22/24, 16:09 -
core-ci voted on patch set 3 V -1 03/22/24, 16:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54854
-
Stefan Bürk uploaded patch set 4
V -103/22/24, 18:11 -
core-ci voted on patch set 4 V -1 03/22/24, 18:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54858
-
Stefan Bürk rebased onto patch set 5
V -103/22/24, 18:28 -
core-ci voted on patch set 5 V -1 03/22/24, 18:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54860
-
Benni Mack commented on patch set 5 CR -1 03/23/24, 20:19
on it -
Stefan Bürk rebased onto patch set 6
CR -1V -103/23/24, 20:23 -
core-ci voted on patch set 6 V -1 03/23/24, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54893
-
Benni Mack uploaded patch set 7
V -103/23/24, 20:51 -
core-ci voted on patch set 7 V -1 03/23/24, 20:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54894
-
Benni Mack uploaded patch set 8
V -103/23/24, 21:11 -
core-ci voted on patch set 8 V +1 03/23/24, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54895
-
Stefan Bürk voted on patch set 8 CR +1 03/23/24, 21:40
-
Stefan Bürk voted on patch set 8 V +1 03/23/24, 21:42
-
Nikita Hovratov commented on patch set 8 CR +1 V +1 03/23/24, 22:06
Nice! It's good that we recently added a bunch of tests regarding pagelayout TypoScript conditions and the TypoScript getData function. -
Benni Mack commented on patch set 8 CR +2 V +2 03/23/24, 22:07
Thanks, Nikita! more to come... -
Benni Mack merged patch set 9 03/23/24, 22:07