Review main Merged

83569[TASK] Update core-testing-php image versions

Stefan Bürk CR +2 V +2 Easy +2 −2 updated 03/22/24, 16:12

Commit message

New core-testing-* images have been build and published in
the TYPO3 testing-infrastructure repository and pulled to
the core ci gitlab runner instances. [1]

This change modifies `Build/Scripts/runTests.sh` to set
new image version to ensure the usage for all changes
based on this change.

For information what changed in the image see the patches
in the testing-infrastrucure repository linked below.

* core-testing-php82 => 1.12
* core-testing-php83 => 1.13

[1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/ebdaefdb54a4fe970abf0cb1d32567bbd6339de5

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Stefan Bürk uploaded patch set 1 03/22/24, 10:49

  2. core-ci voted on patch set 1 V +1 03/22/24, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54838

  3. Stefan Bürk voted on patch set 1 CR -2 03/22/24, 11:05

  4. Stefan Bürk commented on patch set 1 CR 0 03/22/24, 13:49

    NOTE: I already prepared the backports, as backports needs to raise additional images.
  5. Oliver Klee voted on patch set 1 CR +1 V +1 03/22/24, 15:14

  6. Oli Bartsch voted on patch set 1 CR +1 V +1 03/22/24, 15:24

  7. Benjamin Franzke commented on patch set 1 CR +1 V +1 03/22/24, 15:26

    Thanks Stefan for the update. BTW, as far as I see the images do only contain patch-updates of php versions and extensions, that means you could have released 1.12.1 instead of 1.13.0 for PHP 8.3 (maybe possible next time for the php 8.3.5 update?). (My request for minor versions update was to raise the minor version only in case any php extension receives a minor update – or in case some new stuff is added to the images)
  8. Stefan Bürk voted on patch set 1 CR +2 V +2 03/22/24, 16:12

  9. Stefan Bürk merged patch set 2 03/22/24, 16:12