Review main Merged

83572[TASK] Use `SiteConfiguration` from DI in `SiteBasedTestTrait`

Stefan Bürk CR +2 V +2 Easy +2 −12 updated 03/22/24, 15:58

Commit message

`SiteBasedTestTrait` created a instance of the `SiteConfiguration`
using the PHP `new` keyword for writing functional test instance
site configurations.

It is possible, that the `SiteConfiguration` is retrieved from
the `Dependency Injection container` by code executed before
the test releated site configuration is written, which does not
reset the instance based `SiteConfiguration->$firstLevelCache`
property and later retrieving site configurations using the
`SiteFinder`, for example in rootline and other operations,
cannot find the test instance configurations.

This change now uses the `SiteConfiguration` from the test
instance `Dependency Injection container` which ensures that
the internal first level cache is properly reset on `write()`
actions.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 03/22/24, 15:48

  2. core-ci voted on patch set 1 V +1 03/22/24, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54852

  3. Benjamin Franzke voted on patch set 1 CR +1 V +1 03/22/24, 15:56

  4. Benni Mack voted on patch set 1 CR +1 V +1 03/22/24, 15:57

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 03/22/24, 15:58

  6. Stefan Bürk merged patch set 2 03/22/24, 15:58