Review 12.4 Merged

83576[TASK] Account for double click pagetree timeout in acceptance tests

Benjamin Franzke CR +2 V +2 Easy +3 −6 updated 03/23/24, 17:12

Commit message

The page tree in TYPO3 v11 and v12 has a default timeout of 300ms for
click events to be processed (in order to wait for double-click
detection). This caused race conditions in tests since code that
waited for #nprogress to hide after clicking on the pagetree
did not have anything to wait for (yet), because the progress
loaded was only triggered 300ms later, when the click was detected
to not be a double click event and the content frame was started
to be updated.

Also remove wait timeout that were implicitly added for the same
issue, but were spread throughout the test cases.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 816

  1. Benjamin Franzke uploaded patch set 1 03/23/24, 04:49

  2. core-ci voted on patch set 1 V -1 03/23/24, 05:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54867

  3. core-ci commented on patch set 1 03/23/24, 05:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54868

  4. Benjamin Franzke uploaded patch set 2 V -1 03/23/24, 05:15

  5. core-ci voted on patch set 2 V +1 03/23/24, 05:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54869

  6. core-ci commented on patch set 2 03/23/24, 06:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54870

  7. Benjamin Franzke uploaded patch set 3 V +1 03/23/24, 06:37

  8. core-ci voted on patch set 3 V +1 03/23/24, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54871

  9. core-ci commented on patch set 3 03/23/24, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54873

  10. Stefan Bürk voted on patch set 3 CR +1 V +1 03/23/24, 07:31

  11. core-ci commented on patch set 3 03/23/24, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54874

  12. core-ci commented on patch set 3 03/23/24, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54875

  13. Anja Leichsenring voted on patch set 3 CR +1 V +1 03/23/24, 12:36

  14. Oliver Klee voted on patch set 3 CR +1 V +1 03/23/24, 16:36

  15. Benjamin Franzke voted on patch set 3 CR +2 V +2 03/23/24, 17:12

  16. Benjamin Franzke merged patch set 4 03/23/24, 17:12