Review 11.5 Merged

83577[TASK] Account for double click pagetree timeout in acceptance tests

Benjamin Franzke CR +2 V +2 Easy +3 −8 updated 03/23/24, 17:13

Commit message

The page tree in TYPO3 v11 and v12 has a default timeout of 300ms for
click events to be processed (in order to wait for double-click
detection). This caused race conditions in tests since code that
waited for #nprogress to hide after clicking on the pagetree
did not have anything to wait for (yet), because the progress
loaded was only triggered 300ms later, when the click was detected
to not be a double click event and the content frame was started
to be updated.

Also remove wait timeout that were implicitly added for the same
issue, but were spread throughout the test cases.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 415

  1. Benjamin Franzke uploaded patch set 1 03/23/24, 06:37

  2. core-ci voted on patch set 1 V +1 03/23/24, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54872

  3. core-ci voted on patch set 1 V -1 03/23/24, 08:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54876

  4. core-ci voted on patch set 1 V +1 03/23/24, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54876

  5. core-ci voted on patch set 1 V -1 03/23/24, 09:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54877

  6. core-ci commented on patch set 1 03/23/24, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54877

  7. core-ci voted on patch set 1 V +1 03/23/24, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54877

  8. core-ci commented on patch set 1 03/23/24, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54880

  9. Benjamin Franzke uploaded patch set 2 V +1 03/23/24, 12:55

  10. core-ci voted on patch set 2 V +1 03/23/24, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54881

  11. core-ci voted on patch set 2 V -1 03/23/24, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54882

  12. core-ci voted on patch set 2 V +1 03/23/24, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54882

  13. core-ci commented on patch set 2 03/23/24, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54883

  14. Benjamin Franzke voted on patch set 2 CR +2 V +2 03/23/24, 17:12

  15. Benjamin Franzke merged patch set 3 03/23/24, 17:13