Review main Merged

83578[TASK] Move getUserWhoDeleted function to RecordHistory

Torben Hansen CR +2 V +2 Normal +37 −39 updated 03/29/24, 10:01

Commit message

In ext:recycler, there is an open todo to move the function
`getUserWhoDeleted` from `RecyclerAjaxController to `RecordHistory`.

This change moves the function to `RecordHistory` and additionally
renames it to a more appropriate name.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Torben Hansen uploaded patch set 1 03/23/24, 10:03

  2. core-ci voted on patch set 1 V +1 03/23/24, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54878

  3. Benni Mack commented on patch set 1 03/23/24, 22:09

    RecordHistory.php:268

    should we rename the method to make it better to understand? "getUserIdFromDeleteActionForRecord"? or maybe better suggestions?
  4. Torben Hansen uploaded patch set 2 V +1 03/25/24, 07:23

  5. Torben Hansen commented on patch set 2 03/25/24, 07:24

    RecordHistory.php:268 Reply

    Done
  6. core-ci voted on patch set 2 V +1 03/25/24, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54914

  7. Benni Mack voted on patch set 2 CR +1 V +1 03/25/24, 08:15

  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 03/27/24, 09:25

  9. Georg Ringer voted on patch set 2 CR +1 V +1 03/29/24, 10:01

  10. Georg Ringer voted on patch set 2 CR +2 V +2 03/29/24, 10:01

  11. Georg Ringer merged patch set 3 03/29/24, 10:01