Review main Merged

83581[BUGFIX] Fix fetchType in InternalLinktype

Sybille Peters CR +2 V +2 Easy +28 −1 updated 02/10/25, 20:23

Commit message

InternalLinktype::fetchType returns a type, even if the link
type is of type file. The following link types are
mutually exclusive:

- "db" => InternalLinktype
- "file" => FileLinktype

InternalLinktype does not check file links, so it should not
return "db" link type for file links. It only checks page
links.

Also, clarification was added in the comments to make this
clearer.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1320

  1. Sybille Peters uploaded patch set 1 03/23/24, 16:25

  2. Sybille Peters wrote 03/23/24, 16:26

    Topic set to Linkvalidator
  3. core-ci voted on patch set 1 V -1 03/23/24, 16:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54886

  4. Sybille Peters uploaded patch set 2 V -1 03/23/24, 16:45

  5. core-ci voted on patch set 2 V +1 03/23/24, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54889

  6. Benni Mack voted on patch set 2 CR +1 05/03/24, 07:14

  7. Sybille Peters updated the commit message in patch set 3 CR +1 V +1 05/04/24, 08:29

  8. core-ci voted on patch set 3 V -1 05/04/24, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57202

  9. Sybille Peters rebased onto patch set 4 V -1 05/04/24, 09:07

  10. core-ci voted on patch set 4 V +1 05/04/24, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57204

  11. Sybille Peters rebased onto patch set 5 V +1 06/22/24, 05:01

  12. core-ci voted on patch set 5 V +1 06/22/24, 05:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60055

  13. Sybille Peters rebased onto patch set 6 V +1 02/07/25, 14:44

  14. Benni Mack updated the commit message in patch set 7 02/07/25, 14:44

  15. core-ci voted on patch set 7 V +1 02/07/25, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73741

  16. core-ci voted on patch set 6 V +1 02/07/25, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73740

  17. Benni Mack voted on patch set 7 CR +1 V +1 02/10/25, 20:00

  18. Christian Kuhn voted on patch set 7 CR +1 V +1 02/10/25, 20:22

  19. Benni Mack voted on patch set 7 CR +2 V +2 02/10/25, 20:23

  20. Benni Mack merged patch set 8 02/10/25, 20:23