83582[BUGFIX] Fix array access error in LinkAnalyzerResult
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Jörg Bösche +1
- Andreas Kienast +1
-
Verified V +2 Done
- Stefan Bürk +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2025
-
Sybille Peters uploaded patch set 1 03/23/24, 17:12
-
Sybille Peters wrote 03/23/24, 17:13
Topic set to Linkvalidator -
core-ci voted on patch set 1 V -1 03/23/24, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54890
-
Sybille Peters uploaded patch set 2
V -103/23/24, 17:37 -
core-ci voted on patch set 2 V +1 03/23/24, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54891
-
Chris Müller voted on patch set 2 CR +1 03/23/24, 17:48
-
Benni Mack commented on patch set 2 03/23/24, 20:18
LinkAnalyzerResult.php:254there is this method "->fetchOne()" that does exactly this -
Sybille Peters uploaded patch set 3 03/23/24, 21:25
Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 3 V +1 03/23/24, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54896
-
Sybille Peters commented on patch set 3 03/23/24, 23:07
LinkAnalyzerResult.php:254ReplyDone -
Chris Müller commented on patch set 3 CR 0 03/24/24, 17:31
I don't see the use of fetchOne() in the last patchset? -
Sybille Peters uploaded patch set 4
V +103/24/24, 17:43 -
Sybille Peters commented on patch set 4 03/24/24, 17:45
Reply
Right, forgot to commit that. Is fixed now. -
core-ci voted on patch set 4 V +1 03/24/24, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54904
-
Jörg Bösche voted on patch set 4 CR +1 03/25/24, 11:50
-
Christoph Lehmann voted on patch set 4 CR +1 03/26/24, 13:42
-
Sybille Peters updated the commit message in patch set 5
CR +1V +103/26/24, 16:03 -
Sybille Peters commented on patch set 5 03/26/24, 16:03
Updated commit message, because it was no longer correct. Please review again, thanks. -
core-ci voted on patch set 5 V +1 03/26/24, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54982
-
Oliver Klee voted on patch set 5 CR +1 03/26/24, 16:45
-
Stefan Bürk commented on patch set 5 CR +1 V +1 03/27/24, 13:57
Backport note: In v11 needs adoption to Doctrine DBAL 2.x, v12 should be safe (still needs validation) -
Jörg Bösche voted on patch set 5 CR +1 04/04/24, 06:33
-
Andreas Kienast voted on patch set 5 CR +1 V +1 04/05/24, 13:49
-
Stefan Bürk voted on patch set 5 CR +2 V +2 04/05/24, 14:01
-
Stefan Bürk merged patch set 6 04/05/24, 15:20