Review main Merged

83582[BUGFIX] Fix array access error in LinkAnalyzerResult

Sybille Peters CR +2 V +2 Easy +1 −1 updated 04/05/24, 15:20

Commit message

Doctrine dbal function fetchAssociative() was used in combination
with accessing an array element without null colesce.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Jörg Bösche +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2025

  1. Sybille Peters uploaded patch set 1 03/23/24, 17:12

  2. Sybille Peters wrote 03/23/24, 17:13

    Topic set to Linkvalidator
  3. core-ci voted on patch set 1 V -1 03/23/24, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54890

  4. Sybille Peters uploaded patch set 2 V -1 03/23/24, 17:37

  5. core-ci voted on patch set 2 V +1 03/23/24, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54891

  6. Chris Müller voted on patch set 2 CR +1 03/23/24, 17:48

  7. Benni Mack commented on patch set 2 03/23/24, 20:18

    LinkAnalyzerResult.php:254

    there is this method "->fetchOne()" that does exactly this
  8. Sybille Peters uploaded patch set 3 03/23/24, 21:25

    Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  9. core-ci voted on patch set 3 V +1 03/23/24, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54896

  10. Sybille Peters commented on patch set 3 03/23/24, 23:07

    LinkAnalyzerResult.php:254 Reply

    Done
  11. Chris Müller commented on patch set 3 CR 0 03/24/24, 17:31

    I don't see the use of fetchOne() in the last patchset?
  12. Sybille Peters uploaded patch set 4 V +1 03/24/24, 17:43

  13. Sybille Peters commented on patch set 4 03/24/24, 17:45

    Reply

    Right, forgot to commit that. Is fixed now.
  14. core-ci voted on patch set 4 V +1 03/24/24, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54904

  15. Jörg Bösche voted on patch set 4 CR +1 03/25/24, 11:50

  16. Christoph Lehmann voted on patch set 4 CR +1 03/26/24, 13:42

  17. Sybille Peters updated the commit message in patch set 5 CR +1 V +1 03/26/24, 16:03

  18. Sybille Peters commented on patch set 5 03/26/24, 16:03

    Updated commit message, because it was no longer correct. Please review again, thanks.
  19. core-ci voted on patch set 5 V +1 03/26/24, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54982

  20. Oliver Klee voted on patch set 5 CR +1 03/26/24, 16:45

  21. Stefan Bürk commented on patch set 5 CR +1 V +1 03/27/24, 13:57

    Backport note: In v11 needs adoption to Doctrine DBAL 2.x, v12 should be safe (still needs validation)
  22. Jörg Bösche voted on patch set 5 CR +1 04/04/24, 06:33

  23. Andreas Kienast voted on patch set 5 CR +1 V +1 04/05/24, 13:49

  24. Stefan Bürk voted on patch set 5 CR +2 V +2 04/05/24, 14:01

  25. Stefan Bürk merged patch set 6 04/05/24, 15:20