Review main Merged

83593[BUGFIX] Prevent TypeError in DatabaseIntegrityController

Christoph Lehmann CR +2 V +2 Easy +6 −3 updated 05/10/24, 17:54

Commit message

In advanced query the operator "is in list" makes value
be an array. Then switch the field to a non-array field
type, and you get the following TypeError:

```
  htmlspecialchars(): Argument #1 ($string) must be of type
  string, array given.
```

This resets the array value to an empty string.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1623

  1. Christoph Lehmann uploaded patch set 1 03/26/24, 13:08

  2. core-ci voted on patch set 1 V +1 03/26/24, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54967

  3. Stefan Bürk commented on patch set 1 03/27/24, 14:03

    Line length exceeding (not covered by an exclude reason)
    + 12.4
  4. Stefan Bürk updated the commit message in patch set 2 V +1 03/27/24, 14:03

  5. Stefan Bürk updated the commit message in patch set 3 03/27/24, 14:04

  6. Stefan Bürk updated the commit message in patch set 4 03/27/24, 14:04

  7. Stefan Bürk voted on patch set 4 CR +1 V +1 03/27/24, 14:04

  8. core-ci voted on patch set 2 V +1 03/27/24, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55001

  9. core-ci voted on patch set 3 V +1 03/27/24, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55002

  10. core-ci voted on patch set 4 V +1 03/27/24, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55003

  11. Christoph Lehmann commented on patch set 4 05/06/24, 20:32

    thanks!

    Reply

    Done

    Reply

    Done
  12. Oliver Klee updated the commit message in patch set 5 CR +1 V +1 05/06/24, 21:35

  13. Oliver Klee voted on patch set 5 CR +1 05/06/24, 21:36

  14. core-ci voted on patch set 5 V +1 05/06/24, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57297

  15. Benni Mack commented on patch set 5 05/07/24, 05:29

    DatabaseIntegrityController.php:1673

    I assume we need to ensure the key exists? if (is_array($conf['inputValue'] ?? null)) {
  16. Benni Mack commented on patch set 6 CR +1 V +1 05/07/24, 06:41

    Published edit on patch set 5.
  17. Benni Mack updated the commit message in patch set 7 05/07/24, 06:41

  18. Benni Mack commented on patch set 7 CR +1 V +1 05/07/24, 06:41

    DatabaseIntegrityController.php:1673 Reply

    Done
  19. core-ci voted on patch set 6 V +1 05/07/24, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57319

  20. core-ci voted on patch set 7 V +1 05/07/24, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57320

  21. Oliver Klee voted on patch set 7 CR +1 V +1 05/07/24, 09:39

  22. Stefan Bürk voted on patch set 7 CR +2 V +2 05/10/24, 17:28

  23. Stefan Bürk merged patch set 8 05/10/24, 17:54