Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

83594[TASK] Move EXT:frontend default TypoScript to Configuration folder

Benjamin Franzke CR -1 V 0 Normal +31 −30 updated 09/11/25, 19:39

Commit message

In preparation for more TypoScript in EXT:frontend, the
inline TypoScript is not moved from ext_localconf.php
to Configuration/TypoScript.

AbstractInclude is adapted to ensure that the constants include
survives a `unserialize(serialized(…))` chain correctly.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/94/83594/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/94/83594/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • Benjamin Franzke -1
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 3

  1. main 83592[WIP][TASK] Add default content rendering to ext:frontend Based on this change Abandoned Benjamin Franzke CR 0 V 0 Expert +1549 −27
  2. main 83321[TASK] Provide lib.parseFunc via ext:frontend Based on this change Merged Benjamin Kott CR +2 V +2 Normal +127 −3

    The chain has patch set 6 of 18, the changes above it need a rebase.

  3. 83594 [TASK] Move EXT:frontend default TypoScript to Configuration folder This change

Issues 2

Files 4

Review log 45

  1. Benjamin Franzke uploaded patch set 1 03/26/24, 13:42

  2. core-ci voted on patch set 1 V +1 03/26/24, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54971

  3. Benjamin Franzke commented on patch set 1 CR -1 03/26/24, 14:20

    AbstractInclude.php:58 Unresolved

    @lolli@schwarzbu.ch this was needed because tests expect that all IncludeTree objects can be serialized and unserialized and maintain an equivalent object graph, which failed once default imports have been added to ext_localconf.php in wegen https://review.typo3.org/c/Packages/TYPO3.CMS/+/83321/4/typo3/sysext/frontend/ext_localconf.php See failures on https://git.typo3.org/typo3/CI/cms/-/jobs/3140417 I don't have any clue why lineStream (and originalTokenLine in general) was skipped in some conditions. It feels wrong to skip anything (in that case it shouldn't be collected in this object, otherwise we may encounter uncached-execution vs cached-execution bugs). Maybe you can shed some light on that topic?
  4. Benjamin Franzke marked it work in progress 05/30/24, 07:16

  5. Benni Mack commented on patch set 1 09/11/25, 19:39