Review main Merged

83612[FEATURE] Check more fields by default in Link Validator

Sybille Peters CR +2 V +2 Normal +132 −25 updated 09/12/24, 07:25

Commit message

The following fields have been added to the default configuration:

* `pages.canonical_link`
* `sys_redirect.target`
* `sys_file_reference.link`

Other non-working fields (`pages.media`, `tt_content.records`) are
kept for forward-compatibility.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 2633

Show 68 earlier messages
  1. Sybille Peters uploaded patch set 1 03/27/24, 05:42

  2. Sybille Peters wrote 03/27/24, 05:43

    Topic set to Linkvalidator
  3. core-ci voted on patch set 1 V +1 03/27/24, 05:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54987

  4. Sybille Peters uploaded patch set 2 V +1 03/27/24, 05:59

  5. core-ci voted on patch set 2 V +1 03/27/24, 06:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54988

  6. Sybille Peters commented on patch set 2 V -1 04/07/24, 14:49

    Using sys_file_reference.link may result in exception, see also https://github.com/sypets/brofix/issues/358 (brofix uses more or less the same EditableRestriction), should be checked for linkvalidator
  7. Sybille Peters commented on patch set 2 04/08/24, 04:47

  8. Sybille Peters commented on patch set 2 V 0 06/22/24, 05:05

    Reply

    issue was resolved
  1. Sybille Peters commented on patch set 2 06/22/24, 05:07

    page.tsconfig:7

    Question: Would it be breaking if we add fields at this point? Should we add them commented out or only in documentation now?
  2. Garvin Hicking commented on patch set 2 CR +1 V +1 07/11/24, 15:18

    page.tsconfig:7 Reply

    IMO it's more of a bugfix and I personally would opt in to adding these fields as a default. But a good question for mergers.
  3. Oli Bartsch commented on patch set 2 CR -1 07/11/24, 15:27

    Feature-83835-CheckMoreFieldsInLinkValidator.rst:1

    This must be in /13.3/
  4. Sybille Peters uploaded patch set 3 CR +1 V +1 07/11/24, 17:21

  5. Sybille Peters commented on patch set 3 07/11/24, 17:22

    Feature-83835-CheckMoreFieldsInLinkValidator.rst:1 Reply

    Done
  6. core-ci voted on patch set 3 V +1 07/11/24, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61401

  7. Garvin Hicking voted on patch set 3 CR +1 V +1 07/11/24, 19:12

  8. Sybille Peters rebased onto patch set 4 CR +1 V +1 09/04/24, 15:29

  9. Garvin Hicking commented on patch set 4 CR +1 V +1 09/04/24, 15:31

    Rebased; let's see if we can get this finalized somehow.
  10. core-ci voted on patch set 4 V +1 09/04/24, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64778

  11. Benni Mack uploaded patch set 5 CR +1 V +1 09/04/24, 16:28

  12. Benni Mack commented on patch set 5 09/04/24, 16:29

    page.tsconfig:7 Reply

    I personally would keep media and records in the list... because currently they are just skipped, but once we add support for this, we don't need to modify the list again.
  13. Benni Mack commented on patch set 5 09/04/24, 16:31

    page.tsconfig:7 Reply

    while we're at it. Is should we actually configure the list of fields? I mean, we could just define the list of tables and go through all fields with softref, right? With TcaSchema (as done in the patch) we could even improve the analysis further.
  14. core-ci voted on patch set 5 V +1 09/04/24, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64792

  15. Garvin Hicking commented on patch set 5 09/04/24, 16:56

    page.tsconfig:7 Reply

    I don't work too much with LinkAnalyzer but I suppose there could be cases where I check input type=text fields with links, and TYPO3 doesn't know that. Also maybe due to 3rd party extensions. Or I might want to not check csrtain fields because the links there are internal, or irrelevant, or broken "by intent"... We could however do it all by default and make the settings just optional to override the default?
  16. Sybille Peters commented on patch set 5 09/05/24, 09:35

    page.tsconfig:7 Reply

    About "while we're at it. Is should we actually configure the list of fields?": I would prefer it if it is still possible to configure the fields specifically. Perhaps we could use fields "auto" to let linkvaldiator detect all checkable fields. This way people have a choice whether the
  17. Benni Mack commented on patch set 5 09/05/24, 10:26

    page.tsconfig:7 Reply

    we could add "*"...
  18. Garvin Hicking uploaded patch set 6 V +1 09/11/24, 13:12

    Adjust docs and intention
  19. Garvin Hicking commented on patch set 6 09/11/24, 13:18

    page.tsconfig:7 Reply

    Stefan, Sybille and me discussed this. We feel that the '*' evaluation of all softref-able fields should be an isolated feature for the future, as it has a few possible side effects and bug potential. Mainly because some fields might be defined as softrefs, but are not intented to be checked (but would be checked then). So we believe an "opt-in" configuration for checkable fields is more suitable for integrators. See https://forge.typo3.org/issues/104902 for example where this might have a negative impact. The mentioned "currently incompatible" fields (which are not evaluated on linkchecks) are now kept in the default page.tsconfig for forward compatibility.
  20. Garvin Hicking commented on patch set 6 CR +1 V +1 09/11/24, 13:22

    See last comment, scope of this patch is fine by me, and seems to work (tested with default config as proposed).
  21. core-ci voted on patch set 6 V -1 09/11/24, 13:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65449

  22. core-ci voted on patch set 6 V +1 09/11/24, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65449

  23. Stefan Bürk commented on patch set 6 CR +1 V +1 09/12/24, 01:51

    page.tsconfig:7 Reply

    @benni@typo3.org okay for you ?
  24. Benni Mack commented on patch set 6 CR +2 V +2 09/12/24, 07:25

    page.tsconfig:7 Reply

    Done
  25. Benni Mack merged patch set 7 09/12/24, 07:25