Review main Merged

83613[BUGFIX] Fix rechecking of links

Sybille Peters CR +2 V +2 Easy +16 −5 updated 03/27/25, 21:28

Commit message

After a record is edited by opening it from the list of broken links,
it is checked if the link is still in the field. This is only performed
if there was any change. For this purpose, the lastUpdated field is
compared against.

The recheck function is now called with the list of link types
in its correct format.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 3648

Show 1623 earlier messages
  1. Sybille Peters uploaded patch set 1 03/27/24, 17:22

  2. Sybille Peters uploaded patch set 2 03/27/24, 17:27

  3. core-ci voted on patch set 1 V +1 03/27/24, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55004

  4. Sybille Peters wrote 03/27/24, 17:28

    Topic set to Linkvalidator
  5. core-ci voted on patch set 2 V +1 03/27/24, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55005

  6. Georg Ringer voted on patch set 2 CR +1 V +1 03/29/24, 09:49

  7. Stefan Bürk uploaded patch set 3 CR +1 V +1 04/20/24, 21:05

  8. Stefan Bürk uploaded patch set 4 04/20/24, 21:09

  9. core-ci voted on patch set 3 V +1 04/20/24, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56394

  10. core-ci voted on patch set 4 V +1 04/20/24, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56395

  11. Sybille Peters voted on patch set 4 CR +1 V +1 04/21/24, 04:30

  12. Sybille Peters uploaded patch set 5 04/21/24, 04:40

    Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  13. core-ci voted on patch set 5 V +1 04/21/24, 04:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56415

  14. Sybille Peters uploaded patch set 6 CR +1 V +1 04/21/24, 04:55

  15. core-ci voted on patch set 6 V +1 04/21/24, 05:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56418

  16. Sybille Peters commented on patch set 6 CR +1 V +1 04/21/24, 05:23

    I found another problem https://forge.typo3.org/issues/103691 but will create separate patch because it is unrelated and most likely affects different TYPO3 versions.
  17. Sybille Peters uploaded patch set 7 CR +1 V +1 04/21/24, 06:03

  18. core-ci voted on patch set 7 V +1 04/21/24, 06:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56420

  19. Sybille Peters voted on patch set 7 CR +1 V +1 04/21/24, 06:08

  20. Simon Schaufelberger voted on patch set 7 CR +1 05/16/24, 09:13

  21. Georg Ringer voted on patch set 7 CR +1 V +1 06/10/24, 13:15

  22. Garvin Hicking wrote 06/13/24, 12:13

    Removed reviewer Garvin Hicking.
  23. Stefan Bürk voted on patch set 7 CR -1 06/28/24, 12:55

  1. Simon Schaufelberger commented on patch set 7 06/28/24, 14:04

    @stefan@buerk.tech -1 without comment?
  2. Stefan Bürk voted on patch set 7 CR 0 10/16/24, 10:15

  3. Anja Leichsenring commented on patch set 7 10/18/24, 07:41

    this looks like abount resolved with #83835. Can you please confirm the patch is not needed anymore? Thanks.
  4. Oliver Hader updated the commit message in patch set 8 CR +1 V +1 10/18/24, 14:06

  5. Simon Schaufelberger commented on patch set 8 12/06/24, 12:12

    Reply

    @sypets@gmx.de ping
  6. Sybille Peters commented on patch set 8 12/06/24, 14:26

    Reply

    Weird. I can't tell off the top of my head. If you are sure, it is resolved, please abandon. I should be able to take a look by the end of the week.
  7. Sybille Peters commented on patch set 8 12/06/24, 14:33

    Reply

    NO, I can still reproduce this bug (see steps to reproduce): https://forge.typo3.org/issues/103691 with latest main.
  8. Sybille Peters uploaded patch set 9 12/06/24, 14:39

  9. core-ci voted on patch set 9 V +1 12/06/24, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70709

  10. Sybille Peters uploaded patch set 10 V +1 12/06/24, 14:53

  11. Sybille Peters commented on patch set 9 12/06/24, 14:54

    Reply

    The other bug https://forge.typo3.org/issues/103494 was already resolved. I closed it and removed it from the commit message.
  12. core-ci voted on patch set 10 V +1 12/06/24, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70710

  13. Sybille Peters rebased onto patch set 11 V +1 02/11/25, 21:32

  14. Benni Mack commented on patch set 11 02/11/25, 21:32

    Reply

    Stefan, any reasoning?
  15. core-ci voted on patch set 11 V +1 02/11/25, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74010

  16. Stefan Bürk commented on patch set 11 02/12/25, 12:18

    Reply

    Reasong was, that I wanted to * have a look * wait until another change has been merged replacing `$GLOBALS['TCA'] with TcaSchemaFactory to rebase it (which has been done meanwhile) and do it and instead of comment it, but got destracted and than forgot about it. Had now a quick look on current code, looks got except that the commit message is not correct anymore I would say.
  17. Benni Mack uploaded patch set 12 V +1 03/23/25, 22:52

  18. Benni Mack commented on patch set 12 03/23/25, 22:52

    Reply

    I think I also took care of the commit message now, please go ahead with the review now.
  19. core-ci voted on patch set 12 V +1 03/23/25, 23:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76102

  20. Stefan Bürk uploaded patch set 13 V +1 03/27/25, 21:14

  21. Stefan Bürk commented on patch set 13 03/27/25, 21:18

    Reply

    Thanks Benni, beside a minor change fine for me.
  22. Stefan Bürk voted on patch set 13 CR +1 V +1 03/27/25, 21:19

  23. core-ci voted on patch set 13 V +1 03/27/25, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76514

  24. Benni Mack voted on patch set 13 CR +2 V +2 03/27/25, 21:28

  25. Benni Mack merged patch set 14 03/27/25, 21:28