83613[BUGFIX] Fix rechecking of links
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 3648
Show 1623 earlier messages
-
Sybille Peters uploaded patch set 1 03/27/24, 17:22
-
Sybille Peters uploaded patch set 2 03/27/24, 17:27
-
core-ci voted on patch set 1 V +1 03/27/24, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55004
-
Sybille Peters wrote 03/27/24, 17:28
Topic set to Linkvalidator -
core-ci voted on patch set 2 V +1 03/27/24, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55005
-
Georg Ringer voted on patch set 2 CR +1 V +1 03/29/24, 09:49
-
Stefan Bürk uploaded patch set 3
CR +1V +104/20/24, 21:05 -
Stefan Bürk uploaded patch set 4 04/20/24, 21:09
-
core-ci voted on patch set 3 V +1 04/20/24, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56394
-
core-ci voted on patch set 4 V +1 04/20/24, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56395
-
Sybille Peters voted on patch set 4 CR +1 V +1 04/21/24, 04:30
-
Sybille Peters uploaded patch set 5 04/21/24, 04:40
Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 5 V +1 04/21/24, 04:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56415
-
Sybille Peters uploaded patch set 6
CR +1V +104/21/24, 04:55 -
core-ci voted on patch set 6 V +1 04/21/24, 05:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56418
-
Sybille Peters commented on patch set 6 CR +1 V +1 04/21/24, 05:23
I found another problem https://forge.typo3.org/issues/103691 but will create separate patch because it is unrelated and most likely affects different TYPO3 versions. -
Sybille Peters uploaded patch set 7
CR +1V +104/21/24, 06:03 -
core-ci voted on patch set 7 V +1 04/21/24, 06:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56420
-
Sybille Peters voted on patch set 7 CR +1 V +1 04/21/24, 06:08
-
Simon Schaufelberger voted on patch set 7 CR +1 05/16/24, 09:13
-
Georg Ringer voted on patch set 7 CR +1 V +1 06/10/24, 13:15
-
Garvin Hicking wrote 06/13/24, 12:13
Removed reviewer Garvin Hicking. -
Stefan Bürk voted on patch set 7 CR -1 06/28/24, 12:55
-
Simon Schaufelberger commented on patch set 7 06/28/24, 14:04
@stefan@buerk.tech -1 without comment? -
Stefan Bürk voted on patch set 7 CR 0 10/16/24, 10:15
-
Anja Leichsenring commented on patch set 7 10/18/24, 07:41
this looks like abount resolved with #83835. Can you please confirm the patch is not needed anymore? Thanks. -
Oliver Hader updated the commit message in patch set 8
CR +1V +110/18/24, 14:06 -
Simon Schaufelberger commented on patch set 8 12/06/24, 12:12
Reply
@sypets@gmx.de ping -
Sybille Peters commented on patch set 8 12/06/24, 14:26
Reply
Weird. I can't tell off the top of my head. If you are sure, it is resolved, please abandon. I should be able to take a look by the end of the week. -
Sybille Peters commented on patch set 8 12/06/24, 14:33
Reply
NO, I can still reproduce this bug (see steps to reproduce): https://forge.typo3.org/issues/103691 with latest main. -
Sybille Peters uploaded patch set 9 12/06/24, 14:39
-
core-ci voted on patch set 9 V +1 12/06/24, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70709
-
Sybille Peters uploaded patch set 10
V +112/06/24, 14:53 -
Sybille Peters commented on patch set 9 12/06/24, 14:54
Reply
The other bug https://forge.typo3.org/issues/103494 was already resolved. I closed it and removed it from the commit message. -
core-ci voted on patch set 10 V +1 12/06/24, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70710
-
Sybille Peters rebased onto patch set 11
V +102/11/25, 21:32 -
Benni Mack commented on patch set 11 02/11/25, 21:32
Reply
Stefan, any reasoning? -
core-ci voted on patch set 11 V +1 02/11/25, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74010
-
Stefan Bürk commented on patch set 11 02/12/25, 12:18
Reply
Reasong was, that I wanted to * have a look * wait until another change has been merged replacing `$GLOBALS['TCA'] with TcaSchemaFactory to rebase it (which has been done meanwhile) and do it and instead of comment it, but got destracted and than forgot about it. Had now a quick look on current code, looks got except that the commit message is not correct anymore I would say. -
Benni Mack uploaded patch set 12
V +103/23/25, 22:52 -
Benni Mack commented on patch set 12 03/23/25, 22:52
Reply
I think I also took care of the commit message now, please go ahead with the review now. -
core-ci voted on patch set 12 V +1 03/23/25, 23:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76102
-
Stefan Bürk uploaded patch set 13
V +103/27/25, 21:14 -
Stefan Bürk commented on patch set 13 03/27/25, 21:18
Reply
Thanks Benni, beside a minor change fine for me. -
Stefan Bürk voted on patch set 13 CR +1 V +1 03/27/25, 21:19
-
core-ci voted on patch set 13 V +1 03/27/25, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76514
-
Benni Mack voted on patch set 13 CR +2 V +2 03/27/25, 21:28
-
Benni Mack merged patch set 14 03/27/25, 21:28