Review main Merged

83617[TASK] Use ISO 8601 format for date rendering

Mathias Brodala CR +2 V +2 Normal +47 −22 updated 04/03/24, 09:08

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 3038

Show 1113 earlier messages
  1. Mathias Brodala uploaded patch set 1 03/28/24, 09:27

  2. core-ci voted on patch set 1 V -1 03/28/24, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55015

  3. Mathias Brodala uploaded patch set 2 V -1 03/28/24, 09:43

  4. core-ci voted on patch set 2 V +1 03/28/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55016

  5. Mathias Brodala marked it ready for review 03/28/24, 09:57

  6. Stephan Großberndt voted on patch set 2 CR +1 03/28/24, 10:41

  7. Simon Schaufelberger commented on patch set 2 CR +1 V +1 03/28/24, 10:47

    I'm not 100% sure if a core merger would agree to backport this because anyone can adjust the format if needed in their own installation and this would introduce a different default behavior suddenly of a default installation.
  8. Mathias Brodala commented on patch set 2 03/28/24, 10:50

    Reply

    Maybe the backport could adjust the FactoryConfiguration instead to ensure new TYPO3v12 instances use the new default. Accompanied with an Important RST mentioning the upcoming new default. I can also add such an RST here already if desirable.
  9. Stephan Großberndt commented on patch set 2 03/28/24, 10:52

    Reply

    > Maybe the backport could adjust the FactoryConfiguration instead to ensure new TYPO3v12 instances use the new default. Accompanied with an Important RST mentioning the upcoming new default. I can also add such an RST here already if desirable. Good idea!
  10. Mathias Brodala uploaded patch set 3 CR +1 V +1 03/28/24, 10:57

  11. Mathias Brodala commented on patch set 3 03/28/24, 10:58

    Added RST, please vote again.
  12. Stephan Großberndt commented on patch set 4 03/28/24, 11:01

    Published edit on patch set 3.
  13. Stephan Großberndt updated the commit message in patch set 5 03/28/24, 11:02

  1. Stephan Großberndt commented on patch set 5 03/28/24, 11:04

    Could you please adapt the rst-filename to include 8601 as well? thanks
  2. Stephan Großberndt commented on patch set 5 03/28/24, 11:06

    DefaultConfigurationDescription.yaml currently has the text 'Format of Day-Month-Year - see PHP-function <a href="https://php.net/date"; target="_blank" rel="noreferrer">date()</a>' Probably Day-Month-Year should be adapted there as well?
  3. core-ci voted on patch set 4 V +1 03/28/24, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55018

  4. core-ci voted on patch set 5 V +1 03/28/24, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55019

  5. core-ci voted on patch set 3 V +1 03/28/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55017

  6. Mathias Brodala uploaded patch set 6 V +1 03/28/24, 11:10

  7. Mathias Brodala commented on patch set 6 03/28/24, 11:11

    Reply

    OK, done.

    Reply

    I've reworded the description of "ddmmyy" and consequently "hhmm".
  8. core-ci voted on patch set 6 V +1 03/28/24, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55020

  9. Simon Schaufelberger voted on patch set 6 CR +1 V +1 03/28/24, 11:21

  10. Stephan Großberndt uploaded patch set 7 CR +1 V +1 03/28/24, 11:50

  11. Stephan Großberndt voted on patch set 7 CR +1 03/28/24, 11:51

  12. core-ci voted on patch set 7 V +1 03/28/24, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55023

  13. Markus Klein voted on patch set 7 CR +1 03/28/24, 14:07

  14. Kevin Appelt voted on patch set 7 CR +1 03/28/24, 14:09

  15. Simon Schaufelberger voted on patch set 7 CR +1 V +1 03/28/24, 16:12

  16. Benni Mack commented on patch set 7 04/01/24, 21:50

    if we're going to backport this to 12.4, the RST needs to go into 12.4.x folder. In addition, I would appreciate an example in the RST that demonstrates why the existing default syntax can be confusing.
  17. Mathias Brodala uploaded patch set 8 CR +1 V +1 04/02/24, 20:39

  18. Mathias Brodala commented on patch set 8 04/02/24, 20:40

    Reply

    Did both changes, please revote.
  19. core-ci voted on patch set 8 V +1 04/02/24, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55192

  20. Benni Mack voted on patch set 8 CR +1 04/02/24, 21:15

  21. Markus Klein voted on patch set 8 CR +1 V +1 04/03/24, 06:14

  22. Simon Schaufelberger voted on patch set 8 CR +1 V +1 04/03/24, 07:17

  23. Simon Schaufelberger commented on patch set 8 04/03/24, 07:17

    Reply

    Done
  24. Benni Mack voted on patch set 8 CR +2 V +2 04/03/24, 09:08

  25. Benni Mack merged patch set 9 04/03/24, 09:08