Review main Merged

83622[BUGFIX] Respect hidden fields for slug regeneration

Oli Bartsch CR +2 V +2 Easy +3 −3 updated 04/04/24, 07:30

Commit message

To regenerate a slug, the fields defined in
the TCA "generatorOptions" configuration have
to be present in the form.

There are cases where those fields are added as
hidden fields (e.g. using the "overrideValues"
feature). Those fields are now also properly
respected for the regeneration.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Oli Bartsch uploaded patch set 1 03/28/24, 15:29

  2. core-ci voted on patch set 1 V +1 03/28/24, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55030

  3. Oli Bartsch rebased onto patch set 2 V +1 04/03/24, 14:17

  4. core-ci voted on patch set 2 V +1 04/03/24, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55267

  5. Benni Mack voted on patch set 2 CR +1 V +1 04/03/24, 21:11

  6. Andreas Kienast voted on patch set 2 CR +1 V +1 04/04/24, 07:27

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 04/04/24, 07:30

  8. Oli Bartsch merged patch set 3 04/04/24, 07:30