Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
83623[WIP][FEATURE] Introduce System Settings API & Editor
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 61
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/23/83623/61 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/23/83623/61 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 6
- main 90232[WIP][TASK] Implement feature toggles via settings API
- main 90231[WIP][TASK] Add system settings as first level backend module
- main 90197[WIP][TASK] Drop "Extension Configuration"
- main 87687[WIP][TASK] Drop ext_conf_template with "LocalConfiguration" synchronisation
- main 90196[WIP][TASK] Drop "Configure Installation-Wide Options"
-
83623 [WIP][FEATURE] Introduce System Settings API & Editor This change
Issues 1
Files 59
- Build/Scripts/setupAcceptanceComposer.sh+1 −1
- Build/Sources/Sass/component/_settings.scss+1 −0
- Build/Sources/TypeScript/backend/settings/editor/editable-setting.ts+21 −3
- Build/Sources/TypeScript/backend/settings/type/mixed.tsnew+50 −0
- Build/Sources/TypeScript/backend/settings/type/secret.tsnew+51 −0
- Build/Sources/TypeScript/backend/settings/editor.ts+2 −0
- Build/Sources/TypeScript/install/module/settings/system-settings.tsnew+137 −0
- typo3/sysext/backend/Classes/Controller/SiteSettingsController.php+7 −1
- typo3/sysext/backend/Classes/Dto/Settings/EditableSetting.php+1 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_sitesettings.xlf+3 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/settings/editor/editable-setting.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/mixed.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/secret.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/editor.js+1 −1
- typo3/sysext/core/Classes/Attribute/AsSetting.phpnew+51 −0
- typo3/sysext/core/Classes/Attribute/AsSettings.php2new+27 −0
- typo3/sysext/core/Classes/Attribute/Setting.phpnew+36 −0
- typo3/sysext/core/Classes/Core/BootService.php+5 −0
- typo3/sysext/core/Classes/Core/Bootstrap.php+14 −0
Show 39 more files
- typo3/sysext/core/Classes/DependencyInjection/SettingsViewPass.phpnew+100 −0
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php+14 −0
- typo3/sysext/core/Classes/Settings/Type/BoolType.php+1 −0
- typo3/sysext/core/Classes/Settings/Type/IntType.php+9 −1
- typo3/sysext/core/Classes/Settings/Type/MixedType.phpnew+50 −0
- typo3/sysext/core/Classes/Settings/Type/SecretType.phpnew+57 −0
- typo3/sysext/core/Classes/Settings/Type/StringListType.php+1 −1
- typo3/sysext/core/Classes/Settings/Type/StringMapType.phpnew+87 −0
- typo3/sysext/core/Classes/Settings/ExtConfTemplateSettingDefinitionsProvider.phpnew+195 −0
- typo3/sysext/core/Classes/Settings/SettingDefinition.php+1 −0
- typo3/sysext/core/Classes/Settings/Settings.php+15 −1
- typo3/sysext/core/Classes/Settings/SettingsDefinitionsCollection.phpnew+92 −0
- typo3/sysext/core/Classes/Settings/SettingsDiff.php+34 −12
- typo3/sysext/core/Classes/Settings/SettingsFactory.php+4 −3
- typo3/sysext/core/Classes/Settings/SettingsManager.phpnew+93 −0
- typo3/sysext/core/Classes/Settings/SettingsRegistry.php2new+84 −0
- typo3/sysext/core/Classes/Settings/SettingsTypeRegistry.php+2 −0
- typo3/sysext/core/Classes/Settings/TypedSettingsTrait.phpnew+72 −0
- typo3/sysext/core/Classes/Settings/YamlSettingDefinitionsProvider.phpnew+48 −0
- typo3/sysext/core/Classes/TypoScript/AST/Visitor/AstConstantCommentVisitor.php+2 −1
- typo3/sysext/core/Classes/ServiceProvider.php+29 −3
- typo3/sysext/core/Configuration/Services.php+15 −0
- typo3/sysext/core/Configuration/Services.yaml+15 −5
- typo3/sysext/core/Configuration/settings.definitions.yamlnew+1238 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/FalMetadataCest.php+1 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlineContentElementLocalizeSynchronizeCest.php+1 −0
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/LoginCest.php+3 −2
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/SettingsCest.php+68 −0
- typo3/sysext/core/Tests/Unit/Settings/Type/IntTypeTest.php+3 −2
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php+3 −3
- typo3/sysext/frontend/Classes/Middleware/BackendUserAuthenticator.php+8 −3
- typo3/sysext/install/Classes/Controller/SettingsController.php+159 −0
- typo3/sysext/install/Classes/ServiceProvider.php+1 −0
- typo3/sysext/install/Resources/Private/Templates/Settings/Cards.html+9 −0
- typo3/sysext/install/Resources/Public/JavaScript/module/settings/system-settings.jsnew+13 −0
- typo3/sysext/scheduler/Classes/Scheduler.php+7 −22
- typo3/sysext/scheduler/Classes/Settings.phpnew+36 −0
- typo3/sysext/scheduler/ext_conf_template.txt+1 −1
- typo3/sysext/styleguide/ext_emconf.php+2 −2
Review log 69134
Show 57109 earlier messages
-
Benjamin Franzke uploaded patch set 1 03/28/24, 15:54
-
Benjamin Franzke marked it work in progress 03/28/24, 15:54
-
core-ci voted on patch set 1 V -1 03/28/24, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55035
-
Benjamin Franzke uploaded patch set 2
V -103/28/24, 16:53 -
core-ci voted on patch set 2 V -1 03/28/24, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55040
-
Benjamin Franzke uploaded patch set 3
V -103/28/24, 19:29 -
core-ci voted on patch set 3 V -1 03/28/24, 19:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55043
-
Benjamin Franzke uploaded patch set 4
V -103/28/24, 19:56 -
core-ci voted on patch set 4 V +1 03/28/24, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55045
-
Benjamin Franzke uploaded patch set 5
V +103/28/24, 20:16 -
core-ci voted on patch set 5 V +1 03/28/24, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55047
-
Benjamin Franzke uploaded patch set 6
V +103/29/24, 05:55 -
core-ci voted on patch set 6 V +1 03/29/24, 06:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55056
-
Benjamin Franzke uploaded patch set 7
V +104/02/24, 07:09 -
core-ci voted on patch set 7 V +1 04/02/24, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55126
-
Benjamin Franzke uploaded patch set 8
V +104/02/24, 12:41 -
core-ci voted on patch set 8 V +1 04/02/24, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55165
-
Benjamin Franzke uploaded patch set 9
V +104/02/24, 14:23 -
core-ci voted on patch set 9 V +1 04/02/24, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55181
-
Oliver Hader commented on patch set 9 04/03/24, 10:46
SettingsRegistry.php:37Should this be scoped (e.g. `readonly` + accessor methods)? -
Benjamin Franzke uploaded patch set 10
V +104/05/24, 21:04 -
core-ci voted on patch set 10 V -1 04/05/24, 21:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55403
-
Benjamin Franzke uploaded patch set 11
V -104/05/24, 22:47 -
core-ci voted on patch set 11 V -1 04/05/24, 22:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55404
-
Benjamin Franzke uploaded patch set 12
V -104/06/24, 09:02 -
core-ci voted on patch set 12 V +1 04/06/24, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55432
-
Benjamin Franzke uploaded patch set 13
V +104/06/24, 15:59 -
core-ci voted on patch set 13 V +1 04/06/24, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55444
-
Benjamin Franzke rebased onto patch set 14
V +104/06/24, 16:27 -
core-ci voted on patch set 14 V +1 04/06/24, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55449
-
Benjamin Franzke uploaded patch set 15
V +104/07/24, 00:19 -
core-ci voted on patch set 15 V +1 04/07/24, 00:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55465
-
Benjamin Franzke rebased onto patch set 16
V +104/19/24, 07:28 -
core-ci voted on patch set 16 V +1 04/19/24, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56303
-
Benjamin Franzke rebased onto patch set 17
V +104/19/24, 12:52 -
core-ci voted on patch set 17 V +1 04/19/24, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56340
-
Benjamin Franzke rebased onto patch set 18
V +104/24/24, 06:50 -
core-ci voted on patch set 18 V +1 04/24/24, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56639
-
Benjamin Franzke uploaded patch set 19
V +107/05/24, 09:24 -
core-ci voted on patch set 19 V -1 07/05/24, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61030
-
Benjamin Franzke uploaded patch set 20
V -108/08/24, 09:33 -
core-ci voted on patch set 20 V -1 08/08/24, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63037
-
Benjamin Franzke uploaded patch set 21
V -108/16/24, 08:52 -
core-ci voted on patch set 21 V -1 08/16/24, 09:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63566
-
Benjamin Franzke uploaded patch set 22
V -108/29/24, 11:25 -
core-ci voted on patch set 22 V -1 08/29/24, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64469
-
Benjamin Franzke uploaded patch set 23
V -108/29/24, 11:57 -
core-ci voted on patch set 23 V +1 08/29/24, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64470
-
Benjamin Franzke uploaded patch set 24
V +108/30/24, 07:27 -
core-ci voted on patch set 24 V +1 08/30/24, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64512
-
Benjamin Franzke uploaded patch set 25
V +109/11/24, 11:40 -
core-ci voted on patch set 25 V -1 09/11/24, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65424
-
Michael Schams wrote 09/11/24, 11:49
Removed cc Michael Schams. -
Benjamin Franzke uploaded patch set 26
V -109/11/24, 12:19 -
core-ci voted on patch set 26 V +1 09/11/24, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65433
-
Benjamin Franzke uploaded patch set 27
V +109/11/24, 12:27 -
core-ci voted on patch set 27 V +1 09/11/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65436
-
Benjamin Franzke uploaded patch set 28
V +109/11/24, 12:33 -
core-ci voted on patch set 28 V +1 09/11/24, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65439
-
Benjamin Franzke uploaded patch set 29
V +109/11/24, 20:44 -
core-ci voted on patch set 29 V +1 09/11/24, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65496
-
Benjamin Franzke uploaded patch set 30
V +109/12/24, 08:09 -
core-ci voted on patch set 30 V -1 09/12/24, 08:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65536
-
Benjamin Franzke uploaded patch set 31
V -109/12/24, 09:16 -
core-ci voted on patch set 31 V -1 09/12/24, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65548
-
Benjamin Franzke uploaded patch set 32
V -109/12/24, 09:31 -
core-ci voted on patch set 32 V +1 09/12/24, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65550
-
Benjamin Franzke uploaded patch set 33
V +109/13/24, 09:30 -
Benjamin Franzke commented on patch set 33 09/13/24, 09:32
AsSettings.php:24ReplyNo, it's an extensible API, extensions are allowed to implement own settings types, and enum's are not extensible (unfortunately).SettingsRegistry.php:37ReplyI've removed the `view` concept. -
core-ci voted on patch set 33 V -1 09/13/24, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65648
-
Benjamin Franzke uploaded patch set 34
V -109/13/24, 11:32 -
core-ci voted on patch set 34 V +1 09/13/24, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65671
-
Benjamin Franzke uploaded patch set 35
V +109/13/24, 13:13 -
core-ci voted on patch set 35 V -1 09/13/24, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65679
-
Benjamin Franzke uploaded patch set 36
V -109/13/24, 13:29 -
core-ci voted on patch set 36 V +1 09/13/24, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65682
-
Benjamin Franzke uploaded patch set 37
V +109/13/24, 16:12 -
Benjamin Franzke updated the commit message in patch set 38 09/13/24, 16:17
-
core-ci voted on patch set 37 V +1 09/13/24, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65698
-
core-ci voted on patch set 38 V +1 09/13/24, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65699
-
Benjamin Franzke uploaded patch set 39
V +109/14/24, 04:35 -
core-ci voted on patch set 39 V +1 09/14/24, 04:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65737
-
Benjamin Franzke uploaded patch set 40
V +109/16/24, 06:29 -
core-ci voted on patch set 40 V +1 09/16/24, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65849
-
Benjamin Franzke uploaded patch set 41
V +109/16/24, 09:59 -
core-ci voted on patch set 41 V +1 09/16/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65871
-
Benjamin Franzke uploaded patch set 42
V +109/16/24, 12:37 -
core-ci voted on patch set 42 V -1 09/16/24, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65886
-
core-ci commented on patch set 42 09/16/24, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65886
-
core-ci commented on patch set 42 09/16/24, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65886
-
Benjamin Franzke rebased onto patch set 43
V -109/16/24, 15:03 -
core-ci voted on patch set 43 V -1 09/16/24, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65900
-
Benjamin Franzke commented on patch set 43 CR -2 09/16/24, 15:19
-1 Not gonna make it for 13.3 -
Benjamin Franzke uploaded patch set 44
V -109/16/24, 19:53Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 44 V +1 09/16/24, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65921
-
Benjamin Franzke uploaded patch set 45
V +109/17/24, 03:49Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 45 V -1 09/17/24, 04:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65935
-
Benjamin Franzke uploaded patch set 46
V -109/17/24, 04:06Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 46 V +1 09/17/24, 04:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65938
-
Benjamin Franzke marked it work in progress 10/07/24, 09:45
-
Benjamin Franzke uploaded patch set 47
V +101/09/25, 13:36Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 47 V -1 01/09/25, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72140
-
Benjamin Franzke uploaded patch set 48
V -101/09/25, 13:53Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 48 V -1 01/09/25, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72141
-
Benjamin Franzke uploaded patch set 49
V -101/10/25, 08:20Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 49 V +1 01/10/25, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72192
-
Benjamin Franzke commented on patch set 49 CR 0 01/10/25, 10:01
Reply
Done -
Benjamin Franzke uploaded patch set 50
V +107/24/25, 07:02 -
core-ci voted on patch set 50 V -1 07/24/25, 07:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82220
-
Benjamin Franzke uploaded patch set 51
V -107/29/25, 13:03 -
core-ci voted on patch set 51 V -1 07/29/25, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82494
-
core-ci commented on patch set 51 07/29/25, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82494
-
Benjamin Franzke uploaded patch set 52
V -107/30/25, 06:06 -
core-ci voted on patch set 52 V -1 07/30/25, 06:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82535
-
Benjamin Franzke uploaded patch set 53
V -107/30/25, 06:35 -
core-ci voted on patch set 53 V -1 07/30/25, 06:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82536
-
Benjamin Franzke uploaded patch set 54
V -107/30/25, 06:45 -
core-ci voted on patch set 54 V +1 07/30/25, 06:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82537
-
Benjamin Franzke rebased onto patch set 55
V +107/30/25, 08:30 -
core-ci voted on patch set 55 V +1 07/30/25, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82548
-
Benjamin Franzke uploaded patch set 56
V +108/04/25, 10:03 -
core-ci voted on patch set 56 V -1 08/04/25, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82739
-
core-ci voted on patch set 56 V +1 08/04/25, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82739
-
Benjamin Franzke uploaded patch set 57
V +109/16/25, 11:30 -
core-ci voted on patch set 57 V -1 09/16/25, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85026
-
Benjamin Franzke uploaded patch set 58
V -109/17/25, 08:55 -
core-ci voted on patch set 58 V +1 09/17/25, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85065
-
Benjamin Franzke uploaded patch set 59
V +109/17/25, 10:45 -
core-ci voted on patch set 59 V -1 09/17/25, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85066
-
Benjamin Franzke uploaded patch set 60
V -109/22/25, 08:46 -
core-ci voted on patch set 60 V -1 09/22/25, 08:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85280
-
Benjamin Franzke uploaded patch set 61
V -109/22/25, 09:19 -
core-ci voted on patch set 61 V +1 09/22/25, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85282
-
Benjamin Franzke wrote 10/22/25, 09:11
Hashtag added: settings
AsSettings.php:24