Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

83623[WIP][FEATURE] Introduce System Settings API & Editor

Benjamin Franzke CR 0 V 0 Nightmare +3009 −70 updated 10/22/25, 09:11

Commit message

The recently introduced Site Set settings.definitions.yaml API
is now exposed for System Settings as well.

The API is intended to replace the internal DefaultDescription.yaml
and extension ext_conf_template APIs.

Additional system settings can be defined by Setting objects
via PHP attributes, allowed to implicitly define settings
and inject them in consuming code.

The System Settings Editor shares the codebase with the site settings
editor, while persistence and settings composition is adapted for the
specific needs of TYPO3 system settings.

TODO:
 * Maybe remove defined defaults from
   DefaultConfiguration.php
   (that are not needed during bootstrap)
 * Maybe leave-out ext_conf_template bridge for now
 * Implement missing types (or drop them for the definitions for now)
   * Add a custom type of lockRootPath (it is string or array)
 * Overhaul `secret` type
 * Allow null values?
 * probably more…

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 61
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/23/83623/61 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/23/83623/61 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 6

  1. main 90232[WIP][TASK] Implement feature toggles via settings API Based on this change Work in progress Benjamin Franzke CR 0 V -1 Easy +27 −17
  2. main 90231[WIP][TASK] Add system settings as first level backend module Based on this change Work in progress Merge conflict Benjamin Franzke CR 0 V 0 Normal +173 −0
  3. main 90197[WIP][TASK] Drop "Extension Configuration" Based on this change Work in progress Merge conflict Benjamin Franzke CR 0 V 0 Hard +3 −535
  4. main 87687[WIP][TASK] Drop ext_conf_template with "LocalConfiguration" synchronisation Based on this change Work in progress Merge conflict Benjamin Franzke CR 0 V 0 Normal +28 −127
  5. main 90196[WIP][TASK] Drop "Configure Installation-Wide Options" Based on this change Work in progress Merge conflict Benjamin Franzke CR 0 V 0 Hard +2 −797
  6. 83623 [WIP][FEATURE] Introduce System Settings API & Editor This change

Issues 1

Files 59

Show 39 more files

Review log 69134

Show 57109 earlier messages
  1. Benjamin Franzke uploaded patch set 1 03/28/24, 15:54

  2. Benjamin Franzke marked it work in progress 03/28/24, 15:54

  3. core-ci voted on patch set 1 V -1 03/28/24, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55035

  4. Benjamin Franzke uploaded patch set 2 V -1 03/28/24, 16:53

  5. core-ci voted on patch set 2 V -1 03/28/24, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55040

  6. Benjamin Franzke uploaded patch set 3 V -1 03/28/24, 19:29

  7. core-ci voted on patch set 3 V -1 03/28/24, 19:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55043

  8. Benjamin Franzke uploaded patch set 4 V -1 03/28/24, 19:56

  9. core-ci voted on patch set 4 V +1 03/28/24, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55045

  10. Benjamin Franzke uploaded patch set 5 V +1 03/28/24, 20:16

  11. core-ci voted on patch set 5 V +1 03/28/24, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55047

  12. Benjamin Franzke uploaded patch set 6 V +1 03/29/24, 05:55

  13. core-ci voted on patch set 6 V +1 03/29/24, 06:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55056

  14. Benjamin Franzke uploaded patch set 7 V +1 04/02/24, 07:09

  15. core-ci voted on patch set 7 V +1 04/02/24, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55126

  16. Benjamin Franzke uploaded patch set 8 V +1 04/02/24, 12:41

  17. core-ci voted on patch set 8 V +1 04/02/24, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55165

  18. Benjamin Franzke uploaded patch set 9 V +1 04/02/24, 14:23

  19. core-ci voted on patch set 9 V +1 04/02/24, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55181

  20. Oliver Hader commented on patch set 9 04/03/24, 10:46

    AsSettings.php:24

    Should we limit the available types to `enum` values?

    SettingsRegistry.php:37

    Should this be scoped (e.g. `readonly` + accessor methods)?
  21. Benjamin Franzke uploaded patch set 10 V +1 04/05/24, 21:04

  22. core-ci voted on patch set 10 V -1 04/05/24, 21:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55403

  23. Benjamin Franzke uploaded patch set 11 V -1 04/05/24, 22:47

  24. core-ci voted on patch set 11 V -1 04/05/24, 22:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55404

  25. Benjamin Franzke uploaded patch set 12 V -1 04/06/24, 09:02

  26. core-ci voted on patch set 12 V +1 04/06/24, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55432

  27. Benjamin Franzke uploaded patch set 13 V +1 04/06/24, 15:59

  28. core-ci voted on patch set 13 V +1 04/06/24, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55444

  29. Benjamin Franzke rebased onto patch set 14 V +1 04/06/24, 16:27

  30. core-ci voted on patch set 14 V +1 04/06/24, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55449

  31. Benjamin Franzke uploaded patch set 15 V +1 04/07/24, 00:19

  32. core-ci voted on patch set 15 V +1 04/07/24, 00:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55465

  33. Benjamin Franzke rebased onto patch set 16 V +1 04/19/24, 07:28

  34. core-ci voted on patch set 16 V +1 04/19/24, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56303

  35. Benjamin Franzke rebased onto patch set 17 V +1 04/19/24, 12:52

  36. core-ci voted on patch set 17 V +1 04/19/24, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56340

  37. Benjamin Franzke rebased onto patch set 18 V +1 04/24/24, 06:50

  38. core-ci voted on patch set 18 V +1 04/24/24, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56639

  39. Benjamin Franzke uploaded patch set 19 V +1 07/05/24, 09:24

  40. core-ci voted on patch set 19 V -1 07/05/24, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61030

  41. Benjamin Franzke uploaded patch set 20 V -1 08/08/24, 09:33

  42. core-ci voted on patch set 20 V -1 08/08/24, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63037

  43. Benjamin Franzke uploaded patch set 21 V -1 08/16/24, 08:52

  44. core-ci voted on patch set 21 V -1 08/16/24, 09:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63566

  45. Benjamin Franzke uploaded patch set 22 V -1 08/29/24, 11:25

  46. core-ci voted on patch set 22 V -1 08/29/24, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64469

  47. Benjamin Franzke uploaded patch set 23 V -1 08/29/24, 11:57

  48. core-ci voted on patch set 23 V +1 08/29/24, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64470

  49. Benjamin Franzke uploaded patch set 24 V +1 08/30/24, 07:27

  50. core-ci voted on patch set 24 V +1 08/30/24, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64512

  51. Benjamin Franzke uploaded patch set 25 V +1 09/11/24, 11:40

  52. core-ci voted on patch set 25 V -1 09/11/24, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65424

  53. Michael Schams wrote 09/11/24, 11:49

    Removed cc Michael Schams.
  54. Benjamin Franzke uploaded patch set 26 V -1 09/11/24, 12:19

  55. core-ci voted on patch set 26 V +1 09/11/24, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65433

  56. Benjamin Franzke uploaded patch set 27 V +1 09/11/24, 12:27

  57. core-ci voted on patch set 27 V +1 09/11/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65436

  58. Benjamin Franzke uploaded patch set 28 V +1 09/11/24, 12:33

  59. core-ci voted on patch set 28 V +1 09/11/24, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65439

  60. Benjamin Franzke uploaded patch set 29 V +1 09/11/24, 20:44

  61. core-ci voted on patch set 29 V +1 09/11/24, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65496

  62. Benjamin Franzke uploaded patch set 30 V +1 09/12/24, 08:09

  63. core-ci voted on patch set 30 V -1 09/12/24, 08:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65536

  64. Benjamin Franzke uploaded patch set 31 V -1 09/12/24, 09:16

  65. core-ci voted on patch set 31 V -1 09/12/24, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65548

  66. Benjamin Franzke uploaded patch set 32 V -1 09/12/24, 09:31

  67. core-ci voted on patch set 32 V +1 09/12/24, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65550

  68. Benjamin Franzke uploaded patch set 33 V +1 09/13/24, 09:30

  69. Benjamin Franzke commented on patch set 33 09/13/24, 09:32

    AsSettings.php:24 Reply

    No, it's an extensible API, extensions are allowed to implement own settings types, and enum's are not extensible (unfortunately).

    SettingsRegistry.php:37 Reply

    I've removed the `view` concept.
  70. core-ci voted on patch set 33 V -1 09/13/24, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65648

  71. Benjamin Franzke uploaded patch set 34 V -1 09/13/24, 11:32

  72. core-ci voted on patch set 34 V +1 09/13/24, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65671

  73. Benjamin Franzke uploaded patch set 35 V +1 09/13/24, 13:13

  74. core-ci voted on patch set 35 V -1 09/13/24, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65679

  75. Benjamin Franzke uploaded patch set 36 V -1 09/13/24, 13:29

  76. core-ci voted on patch set 36 V +1 09/13/24, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65682

  77. Benjamin Franzke uploaded patch set 37 V +1 09/13/24, 16:12

  78. Benjamin Franzke updated the commit message in patch set 38 09/13/24, 16:17

  79. core-ci voted on patch set 37 V +1 09/13/24, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65698

  80. core-ci voted on patch set 38 V +1 09/13/24, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65699

  81. Benjamin Franzke uploaded patch set 39 V +1 09/14/24, 04:35

  82. core-ci voted on patch set 39 V +1 09/14/24, 04:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65737

  83. Benjamin Franzke uploaded patch set 40 V +1 09/16/24, 06:29

  84. core-ci voted on patch set 40 V +1 09/16/24, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65849

  85. Benjamin Franzke uploaded patch set 41 V +1 09/16/24, 09:59

  86. core-ci voted on patch set 41 V +1 09/16/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65871

  87. Benjamin Franzke uploaded patch set 42 V +1 09/16/24, 12:37

  88. core-ci voted on patch set 42 V -1 09/16/24, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65886

  89. core-ci commented on patch set 42 09/16/24, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65886

  90. core-ci commented on patch set 42 09/16/24, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65886

  91. Benjamin Franzke rebased onto patch set 43 V -1 09/16/24, 15:03

  92. core-ci voted on patch set 43 V -1 09/16/24, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65900

  93. Benjamin Franzke commented on patch set 43 CR -2 09/16/24, 15:19

    -1 Not gonna make it for 13.3
  94. Benjamin Franzke uploaded patch set 44 V -1 09/16/24, 19:53

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  95. core-ci voted on patch set 44 V +1 09/16/24, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65921

  96. Benjamin Franzke uploaded patch set 45 V +1 09/17/24, 03:49

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  97. core-ci voted on patch set 45 V -1 09/17/24, 04:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65935

  98. Benjamin Franzke uploaded patch set 46 V -1 09/17/24, 04:06

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  99. core-ci voted on patch set 46 V +1 09/17/24, 04:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65938

  100. Benjamin Franzke marked it work in progress 10/07/24, 09:45

  101. Benjamin Franzke uploaded patch set 47 V +1 01/09/25, 13:36

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  102. core-ci voted on patch set 47 V -1 01/09/25, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72140

  103. Benjamin Franzke uploaded patch set 48 V -1 01/09/25, 13:53

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  104. core-ci voted on patch set 48 V -1 01/09/25, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72141

  105. Benjamin Franzke uploaded patch set 49 V -1 01/10/25, 08:20

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  106. core-ci voted on patch set 49 V +1 01/10/25, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72192

  107. Benjamin Franzke commented on patch set 49 CR 0 01/10/25, 10:01

    Reply

    Done
  108. Benjamin Franzke uploaded patch set 50 V +1 07/24/25, 07:02

  109. core-ci voted on patch set 50 V -1 07/24/25, 07:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82220

  1. Benjamin Franzke uploaded patch set 51 V -1 07/29/25, 13:03

  2. core-ci voted on patch set 51 V -1 07/29/25, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82494

  3. core-ci commented on patch set 51 07/29/25, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82494

  4. Benjamin Franzke uploaded patch set 52 V -1 07/30/25, 06:06

  5. core-ci voted on patch set 52 V -1 07/30/25, 06:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82535

  6. Benjamin Franzke uploaded patch set 53 V -1 07/30/25, 06:35

  7. core-ci voted on patch set 53 V -1 07/30/25, 06:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82536

  8. Benjamin Franzke uploaded patch set 54 V -1 07/30/25, 06:45

  9. core-ci voted on patch set 54 V +1 07/30/25, 06:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82537

  10. Benjamin Franzke rebased onto patch set 55 V +1 07/30/25, 08:30

  11. core-ci voted on patch set 55 V +1 07/30/25, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82548

  12. Benjamin Franzke uploaded patch set 56 V +1 08/04/25, 10:03

  13. core-ci voted on patch set 56 V -1 08/04/25, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82739

  14. core-ci voted on patch set 56 V +1 08/04/25, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82739

  15. Benjamin Franzke uploaded patch set 57 V +1 09/16/25, 11:30

  16. core-ci voted on patch set 57 V -1 09/16/25, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85026

  17. Benjamin Franzke uploaded patch set 58 V -1 09/17/25, 08:55

  18. core-ci voted on patch set 58 V +1 09/17/25, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85065

  19. Benjamin Franzke uploaded patch set 59 V +1 09/17/25, 10:45

  20. core-ci voted on patch set 59 V -1 09/17/25, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85066

  21. Benjamin Franzke uploaded patch set 60 V -1 09/22/25, 08:46

  22. core-ci voted on patch set 60 V -1 09/22/25, 08:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85280

  23. Benjamin Franzke uploaded patch set 61 V -1 09/22/25, 09:19

  24. core-ci voted on patch set 61 V +1 09/22/25, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85282

  25. Benjamin Franzke wrote 10/22/25, 09:11

    Hashtag added: settings