83626[FEATURE] Optimized integration of Page Rendering via Fluid
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Benjamin Kott +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 16
- typo3/sysext/core/Classes/Page/PageLayoutResolver.php+9 −0
- typo3/sysext/core/Documentation/Changelog/13.1/Feature-103504-NewContentObjectPageView.rst13new+153 −0
- typo3/sysext/frontend/Classes/ContentObject/PageViewContentObject.phpnew+194 −0
- typo3/sysext/frontend/Configuration/Services.yaml+5 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/Fixtures/FluidPage/pages.csvnew+4 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/PageViewContentObjectTest.phpnew+82 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Configuration/TypoScript/plain.typoscriptnew+9 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Configuration/page.tsconfignew+63 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Resources/Private/Language/fr.page.xlfnew+12 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Resources/Private/Language/page.xlfnew+11 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Resources/Private/Templates/Layouts/Default.htmlnew+9 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Resources/Private/Templates/Pages/Standard.htmlnew+5 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Resources/Private/templates_in_lowercase/layouts/Default.htmlnew+9 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Resources/Private/templates_in_lowercase/pages/Standard.htmlnew+5 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/composer.jsonnew+14 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/ext_emconf.phpnew+18 −0
Review log 6493
Show 4668 earlier messages
-
Benni Mack uploaded patch set 1 03/29/24, 21:33
-
core-ci voted on patch set 1 V -1 03/29/24, 21:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55070
-
Benni Mack uploaded patch set 2
V -103/29/24, 21:48 -
core-ci voted on patch set 2 V +1 03/29/24, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55071
-
Benni Mack uploaded patch set 3
V +103/29/24, 22:24 -
core-ci voted on patch set 3 V -1 03/29/24, 22:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55072
-
Benni Mack uploaded patch set 4
V -103/29/24, 22:33 -
core-ci voted on patch set 4 V -1 03/29/24, 22:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55073
-
Benni Mack uploaded patch set 5
V -103/29/24, 22:42 -
core-ci voted on patch set 5 V +1 03/29/24, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55074
-
Benni Mack uploaded patch set 6
V +103/29/24, 22:51 -
core-ci voted on patch set 6 V +1 03/29/24, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55075
-
Benni Mack uploaded patch set 7
V +103/29/24, 23:00 -
core-ci voted on patch set 7 V -1 03/29/24, 23:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55076
-
Benni Mack uploaded patch set 8
V -103/29/24, 23:12 -
core-ci voted on patch set 8 V +1 03/29/24, 23:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55077
-
Nikita Hovratov uploaded patch set 9
V +103/30/24, 11:37 -
Nikita Hovratov commented on patch set 9 03/30/24, 11:40
Added an exception if template is not found. Otherwise user has blank page without error. -
core-ci voted on patch set 9 V -1 03/30/24, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55085
-
Nikita Hovratov rebased onto patch set 10
V -103/30/24, 20:18 -
core-ci voted on patch set 10 V +1 03/30/24, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55096
-
Andreas Kienast commented on patch set 10 04/02/24, 07:10
FluidPageContentObject.php:142Nitpick: Multiple `fn` can be static. -
Benjamin Kott commented on patch set 10 CR -1 04/02/24, 07:33
FluidPageContentObject.php:115do we really need to set controller action?FluidPageContentObject.php:116do we really need to set the controller name?FluidPageContentObject.php:143`partials` should be preferred over `Partials`FluidPageContentObject.php:148it should not be allowed to set layoutRootPaths manuallyFluidPageContentObject.php:165`partials` should be preferred over `Partials`FluidPageContentObject.php:169it should not be allowed to set partialRootPaths manually -
Andreas Kienast commented on patch set 10 04/02/24, 07:49
FluidPageContentObject.php:165ReplyOver the course of several TYPO3 releases, we encouraged people to use camel-cased directory names. Changing and forcing this now to lower-cased might become a breaking change, especially when TYPO3 projects are developed on case-insensitive file systems, but are deployed to case-sensitive systems. -
Benni Mack uploaded patch set 11
CR -1V +104/02/24, 07:55 -
core-ci voted on patch set 11 V +1 04/02/24, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55129
-
Benni Mack uploaded patch set 12
V +104/02/24, 10:23 -
Benni Mack commented on patch set 12 04/02/24, 10:25
FluidPageContentObject.php:142ReplyDoneFluidPageContentObject.php:143ReplyDoneFluidPageContentObject.php:148ReplyDoneFluidPageContentObject.php:169ReplyDone -
core-ci voted on patch set 12 V +1 04/02/24, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55149
-
Benni Mack commented on patch set 12 04/02/24, 10:34
FluidPageContentObject.php:115ReplyThis is used to resolve the template name properly in Fluid (thus: pages/Mypagelayout.html)FluidPageContentObject.php:116ReplyThis is used to resolve the template name properly in Fluid (thus: pages/Mypagelayout.html)FluidPageContentObject.php:165ReplyI built it in a way that both variants are allowed. We should slowly get to a point where we reduce the mental load of naming and have integrators (esp. them in this case) not care about the folder structure casing in the future. -
Benni Mack commented on patch set 13
V +104/02/24, 12:35Published edit on patch set 12. -
core-ci voted on patch set 13 V +1 04/02/24, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55164
-
Benjamin Kott commented on patch set 13 CR -1 04/02/24, 12:50
FluidPageContentObject.php:27PAGEVIEWFluidPageContentObject.php:45PageViewContentObjectFluidPageContentObject.php:65PAGEVIEWFluidPageContentObject.php:110i am still unsure about configuring the rendering context. i understood that i´ts used to resolve the templates. but cannot we reduce it to only use setTemplate($layout) from the viewinterface?FluidPageContentObject.php:165ReplyDoneFluidPageContentObject.php:233would remove the stdwrap here alsoFluidPageContentObject.php:253do we really want to support stdwrap here? if we at some point go further and even remove this capability we would need to be breaking here. i would suggest we only resolve the ext: syntax and do not allow additional processing here. -
Benjamin Kott commented on patch set 13 04/02/24, 12:51
FluidPageContentObject.php:115ReplyDoneFluidPageContentObject.php:116ReplyDone -
Oliver Hader commented on patch set 13 04/02/24, 13:12
Feature-103504-NewContentObjectFLUIDPAGE.rst:109Change nesting to make before and after more comparable + add custom variable, e.g. ``` page.10 = FLUIDPAGE page.10 { templates { # refers to previous templateRootPaths, partial~, layout~ 100 = ... } variables { defaultLogoUri = TEXT defaultLogoUri.value = ${...} } dataProcessing { 10 = menu 10.as = mainMenu } } ```FluidPageContentObject.php:75Would it be possible to type-hint `$conf` for new cObjects?FluidPageContentObject.php:135Can be be "strict" here? E.g. either only uppercase or lowercase?FluidPageContentObject.php:180Use `!is_string(..)` instead?FluidPageContentObject.php:193Move this block to the top? Currently those internal variables would override custom assignments... Besides that: `language` vs `siteLanguage` (in `$this->reservedVariables`)FluidPageContentObject.php:230`is_array($conf['stdWrap.'] ?? null)` instead?FluidPageContentObject.php:244... `&& is_array($paths)`?FluidPageContentObject.php:248`is_array($paths[$key . '.'] ?? null)` instead?FluidPageContentObject.php:251Check the result against `isAllowedAbsPath` - e.g. the result might be empty and should not be put to `$finalPaths` -
Benni Mack uploaded patch set 14
CR -1V +104/02/24, 13:29 -
Benni Mack commented on patch set 14 04/02/24, 13:31
FluidPageContentObject.php:135Replysee commit message and RST. It is added for backwards-compatFluidPageContentObject.php:193ReplyDoneFluidPageContentObject.php:244ReplyDoneFluidPageContentObject.php:251ReplyDone -
core-ci voted on patch set 14 V +1 04/02/24, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55167
-
Benjamin Kott commented on patch set 14 04/02/24, 13:37
FluidPageContentObject.php:110ReplyDoneFluidPageContentObject.php:253ReplyDone -
Benni Mack uploaded patch set 15
V +104/02/24, 13:39 -
core-ci voted on patch set 15 V +1 04/02/24, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55168
-
Benni Mack commented on patch set 15 04/02/24, 13:51
FluidPageContentObject.php:27ReplyDoneFluidPageContentObject.php:45ReplyDoneFluidPageContentObject.php:65ReplyDoneFluidPageContentObject.php:233ReplyDone -
Benni Mack uploaded patch set 16
V +104/02/24, 13:57 -
Benni Mack uploaded patch set 17 04/02/24, 13:58
-
Benni Mack commented on patch set 16 04/02/24, 13:58
Feature-103504-NewContentObjectFLUIDPAGE.rst:109ReplyDoneFluidPageContentObject.php:75ReplyDue to Liskov, this does not work (we need to fix "AbstractContentObject" which is a breaking change :( )FluidPageContentObject.php:135ReplyDoneFluidPageContentObject.php:180ReplyDoneFluidPageContentObject.php:230ReplyDoneFluidPageContentObject.php:248ReplyDone -
Benni Mack uploaded patch set 18 04/02/24, 14:02
-
core-ci voted on patch set 17 V +1 04/02/24, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55175
-
Kevin Appelt commented on patch set 18 04/02/24, 14:15
Feature-103504-NewContentObjectPageView.rst:23page.10.paths.100 ?Feature-103504-NewContentObjectPageView.rst:123Use nesting here to make it more obvious that it's nested? -
core-ci voted on patch set 16 V +1 04/02/24, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55174
-
core-ci voted on patch set 18 V +1 04/02/24, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55180
-
Benni Mack uploaded patch set 19
V +104/02/24, 14:29 -
core-ci voted on patch set 19 V +1 04/02/24, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55182
-
Benni Mack commented on patch set 19 04/02/24, 14:56
Feature-103504-NewContentObjectPageView.rst:23ReplyDoneFeature-103504-NewContentObjectPageView.rst:123ReplyDone -
Benjamin Kott commented on patch set 16 CR -1 04/02/24, 15:01
Feature-103504-NewContentObjectPageView.rst:42languageFeature-103504-NewContentObjectPageView.rst:123please format the same way as above -
Benjamin Kott commented on patch set 19 CR -1 04/02/24, 15:04
Feature-103504-NewContentObjectPageView.rst:123ReplyDoneFeature-103504-NewContentObjectPageView.rst:125please format the same way as above -
Benni Mack uploaded patch set 20
CR -1V +104/02/24, 15:11 -
Benni Mack commented on patch set 19 04/02/24, 15:11
Feature-103504-NewContentObjectPageView.rst:42ReplyDoneFeature-103504-NewContentObjectPageView.rst:125ReplyDone -
core-ci voted on patch set 20 V +1 04/02/24, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55183
-
Benni Mack uploaded patch set 21
V +104/02/24, 15:19 -
core-ci voted on patch set 21 V +1 04/02/24, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55184
-
Benjamin Kott voted on patch set 20 CR +1 V +1 04/02/24, 15:43
-
Benni Mack updated the commit message in patch set 22
V +104/02/24, 15:53 -
Benjamin Kott voted on patch set 22 CR +1 V +1 04/02/24, 15:54
-
core-ci voted on patch set 22 V +1 04/02/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55185
-
Nikita Hovratov commented on patch set 22 V -1 04/02/24, 16:54
Please let's also have a test that lowercase "pages" works. Right now it tests only with "Pages". -
Garvin Hicking commented on patch set 22 04/02/24, 17:36
FluidPageContentObject.php:165ReplyI like that casing is aimed to be irrelevant. But seeing a mixture of "Resources/Private/Templates" and then lowercase names in changelog&commit (and thus documentation later) looks odd to me and more like a typo that I would stumble upon. Couldn't a move to future lowercasing be made more consistently, and for the time being, promote the learned Uppercase to not unneccessarly confuse integrators, especially if they maybe have both FLUIDTEMPlATE and PAGEVIEW in effect at the same time? -
Benni Mack uploaded patch set 23
CR +1V +104/02/24, 21:11 -
Benni Mack updated the commit message in patch set 24 04/02/24, 21:12
-
Benni Mack commented on patch set 24 04/02/24, 21:15
FluidPageContentObject.php:165ReplyI took care of it in the RST and the commit message. -
core-ci voted on patch set 23 V -1 04/02/24, 21:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55193
-
core-ci voted on patch set 24 V -1 04/02/24, 21:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55194
-
Benni Mack uploaded patch set 25
V -104/02/24, 21:30 -
core-ci voted on patch set 25 V -1 04/02/24, 21:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55195
-
Benni Mack uploaded patch set 26
V -104/02/24, 21:38 -
core-ci voted on patch set 26 V +1 04/02/24, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55196
-
Stefan Bürk commented on patch set 26 04/02/24, 22:44
Feature-103504-NewContentObjectPageView.rst:38> lower-case or upper-case would mean "PAGES" or "pages", but from reading I would guess `Pages` and `pages` are meant .. so lower-case and upper-camel-case(ucfirst). Not that people assume that "PAGES" would work (on case-sensitve systems it won't). -
Garvin Hicking commented on patch set 26 04/03/24, 05:27
Feature-103504-NewContentObjectPageView.rst:38ReplyI agree on that, maybe just write "can start with a lower-case or upper-case letter". (Also: s/burdon/burden) Thanks for adjusting this! -
Benni Mack commented on patch set 27
V +104/03/24, 05:31Published edit on patch set 26. -
Benni Mack commented on patch set 27 04/03/24, 05:31
Feature-103504-NewContentObjectPageView.rst:38ReplyDone -
core-ci voted on patch set 27 V +1 04/03/24, 05:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55201
-
Benjamin Kott voted on patch set 27 CR +1 V +1 04/03/24, 06:40
-
Oli Bartsch commented on patch set 27 CR -1 04/03/24, 06:42
Reviewing -
Oliver Hader voted on patch set 27 CR +1 04/03/24, 06:57
-
Georg Ringer voted on patch set 27 CR +1 V +1 04/03/24, 07:13
-
Oli Bartsch uploaded patch set 28
CR +1V +104/03/24, 07:53 -
Oli Bartsch uploaded patch set 29
CR +1V +104/03/24, 07:56 -
core-ci voted on patch set 28 V +1 04/03/24, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55207
-
core-ci voted on patch set 29 V +1 04/03/24, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55208
-
Oli Bartsch voted on patch set 29 CR +1 V +1 04/03/24, 08:07
-
Benjamin Kott voted on patch set 29 CR +1 V +1 04/03/24, 09:12
-
Benni Mack voted on patch set 29 CR +2 V +2 04/03/24, 09:13
-
Benni Mack merged patch set 30 04/03/24, 09:13