Review main Merged

83631[BUGFIX] Bring back valuePicker for TCA type `email`

Nikita Hovratov CR +2 V +2 Normal +132 −4 updated 04/02/24, 20:27

Commit message

While extracting dedicated TCA types from the god type `input`, the
`valuePicker` option was forgotten for type `email`. Other types like
`number` do have this option.

An acceptance test is added to ensure this option will not be dropped
by accident in the future.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 810

  1. Nikita Hovratov uploaded patch set 1 03/30/24, 17:02

  2. core-ci voted on patch set 1 V +1 03/30/24, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55095

  3. Benni Mack commented on patch set 1 04/01/24, 21:48

    Hey Nikita, can we have a test for this in order to not "remove it again by accident"?
  4. Nikita Hovratov uploaded patch set 2 V +1 04/02/24, 16:18

  5. core-ci voted on patch set 2 V +1 04/02/24, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55186

  6. Nikita Hovratov commented on patch set 2 04/02/24, 16:25

    Reply

    Added an acceptance test, which chooses a value from valuePicker to ensure this works also in the future.
  7. Georg Ringer voted on patch set 2 CR +1 V +1 04/02/24, 17:31

  8. Benni Mack voted on patch set 2 CR +1 V +1 04/02/24, 19:55

  9. Nikita Hovratov voted on patch set 2 CR +2 V +2 04/02/24, 20:27

  10. Nikita Hovratov merged patch set 3 04/02/24, 20:27