Review main Merged

83632[TASK] Create valid source data for DataHandler tests

André Buchmann CR +2 V +2 Nightmare +2686 −2773 updated 04/26/24, 23:22

Commit message

Tests in DataScenarios/Regular for the DataHandler are based on invalid
source data. There are translated content elements on pages that have
no translations. It's not possible to translate content elements without
having a page translation first in the backend. A lot of the tests use
workarounds and create those missing page translations first.

The tests should be based on valid source data in order to check the
pages and handling of the content.

There is now a dedicated csv file containing tt_content and their
related pages records to run tests with translations. For this reason,
all tests that do not include a page translation process themselves
import the default translations via a separate csv file. Accordingly,
the tests localizePage*, localizeAndCopyPage*, localizeNestedPages* and
movePageLocalized* do not import the default translations.

It is also ensured that no content translation exist in the source data
without a corresponding page translation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Eric Harrer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Eric Harrer +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 307

Show 287 more files

Review log 1931

Show 46 earlier messages
  1. André Buchmann uploaded patch set 1 03/31/24, 13:07

  2. André Buchmann rebased onto patch set 2 03/31/24, 13:13

  3. core-ci voted on patch set 1 V -1 03/31/24, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55103

  4. core-ci voted on patch set 2 V -1 03/31/24, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55104

  5. André Buchmann marked it work in progress 04/06/24, 08:26

  6. André Buchmann uploaded patch set 3 V -1 04/07/24, 09:41

  1. core-ci voted on patch set 3 V -1 04/07/24, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55497

  2. André Buchmann uploaded patch set 4 V -1 04/19/24, 11:09

  3. core-ci voted on patch set 4 V -1 04/19/24, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56330

  4. Eric Harrer uploaded patch set 5 V -1 04/19/24, 16:05

  5. core-ci voted on patch set 5 V -1 04/19/24, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56346

  6. André Buchmann uploaded patch set 6 V -1 04/23/24, 14:26

  7. core-ci voted on patch set 6 V -1 04/23/24, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56587

  8. André Buchmann uploaded patch set 7 V -1 04/23/24, 19:37

  9. core-ci voted on patch set 7 V -1 04/23/24, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56606

  10. André Buchmann uploaded patch set 8 V -1 04/24/24, 13:32

  11. core-ci voted on patch set 8 V -1 04/24/24, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56661

  12. André Buchmann uploaded patch set 9 V -1 04/24/24, 16:25

  13. core-ci voted on patch set 9 V -1 04/24/24, 16:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56665

  14. André Buchmann uploaded patch set 10 V -1 04/25/24, 15:54

  15. core-ci voted on patch set 10 V +1 04/25/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56710

  16. André Buchmann marked it ready for review 04/25/24, 16:45

  17. Eric Harrer commented on patch set 10 CR +1 V +1 04/26/24, 12:21

    ok, so the 306 tests are all green even in the local test environment, I even ran the higher level with 1113 tests successfully. I have also checked all php file changes and found no anomalies. From my point of view everything is plausible and good.
  18. André Buchmann uploaded patch set 11 CR +1 V +1 04/26/24, 12:49

  19. core-ci voted on patch set 11 V +1 04/26/24, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56779

  20. Eric Harrer voted on patch set 11 CR +1 V +1 04/26/24, 14:39

  21. Oliver Klee voted on patch set 11 V +1 04/26/24, 15:03

  22. core-ci commented on patch set 11 04/26/24, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56792

  23. Christian Kuhn commented on patch set 11 CR +2 V +2 04/26/24, 23:19

    Ok, so we now have 4 different import files used within the Regular/ scenario. I understand why this is done in the patch, but I don't like it: All other scenario sets always import exactly one file (one in non-workspace, one in workspace). Having multiple is a bit of a nightmare, since it defeats for instance the 'verifyCleanRefindex()' tests, and makes maintaining especially the refindex even harder. I thus suggest to merge the patch as-is now, and to then split the combinations into different scenario folders, to maintain them standalone and for them to import always only exactly one .csv fixture for simplicity and alignment with the other scenarios. This should also improve overview of the massive 'regular' test set, and allows us to simplify the refindex maintenance of imported .csv fixtures. We should additionally get rid of the per-test imports within the abstracts again, this way.
  24. Christian Kuhn commented on patch set 11 04/26/24, 23:22

    Reply

    note: great work! the fact all these tests worked on kinda broken imports due to the missing page localizations was really a headache. much better with this being resolved now.
  25. Christian Kuhn merged patch set 12 04/26/24, 23:22