Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
83637[FEATURE] Add filter to selectCheckBox fields
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 24
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/37/83637/24 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/37/83637/24 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/form-engine/element/extra/select-check-box-filter.ts16new+98 −0
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php7+9 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/extra/select-check-box-filter.jsnew+13 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-103515-AddedAnOptionToRenderFilterAboveSelectCheckBoxFieldType.rstnew+64 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+3 −0
Review log 5983
Show 4158 earlier messages
-
Marcin Sągol uploaded patch set 1 04/02/24, 11:11
-
Marcin Sągol uploaded patch set 2 04/02/24, 11:13
-
Marcin Sągol uploaded patch set 3 04/02/24, 11:16
-
core-ci voted on patch set 1 V -1 04/02/24, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55151
-
core-ci voted on patch set 2 V -1 04/02/24, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55152
-
core-ci voted on patch set 3 V -1 04/02/24, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55153
-
Marcin Sągol uploaded patch set 4
V -104/02/24, 11:26 -
core-ci voted on patch set 4 V +1 04/02/24, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55154
-
Marcin Sągol updated the commit message in patch set 5
V +104/02/24, 11:35 -
Marcin Sągol updated the commit message in patch set 6 04/02/24, 11:37
-
Garvin Hicking commented on patch set 6 04/02/24, 11:40
With things like this you wonder "hasn't this already existed" :-D Great work on this usability improvement. I wonder though if we really need an extra complexity of the TCA? How about adding that filter input for every checkbox selection that has like more than 5 items? Then an editor could use it directly everywhere, and extensions wouldn't need to be specifically adapted for it...? -
core-ci voted on patch set 5 V +1 04/02/24, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55156
-
core-ci voted on patch set 6 V +1 04/02/24, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55157
-
Simon Schaufelberger commented on patch set 6 04/02/24, 11:55
SelectCheckBoxElement.php:83This can be simplified to: `(bool)($config['showFilter'] ?? false) === true` -
Marcin Sągol uploaded patch set 7
V +104/02/24, 12:08 -
Marcin Sągol commented on patch set 7 04/02/24, 12:11
Reply
I am opened for suggestion :) I think more people should share their thoughts on this. I have followed the hideSuggest configuration approach here - to make it configuratble.SelectCheckBoxElement.php:83ReplyFixed -
core-ci voted on patch set 7 V +1 04/02/24, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55158
-
Oli Bartsch commented on patch set 7 04/02/24, 14:55
aselect-check-box-filter.ts:23Let's make this a web component.select-check-box-element.ts:98Would not be needed as soon as this a web component.SelectCheckBoxElement.php:83Not sure whether this should better be an `appearance` config.be_groups.php:125We could make it TRUE by defaultFeature-103515-AddAnOptionToRenderFilterAboveSelectCheckBoxFieldType.rst:14TCA Type "select" with render type "selectCheckBox"Feature-103515-AddAnOptionToRenderFilterAboveSelectCheckBoxFieldType.rst:17let's use :php: insteadFeature-103515-AddAnOptionToRenderFilterAboveSelectCheckBoxFieldType.rst:45This is only because we set it to true in corresponding TCA. I would mention this. Otherwise it sounds like the default is FALSE and we have some special handling for Backend User / Groups. -
Simon Schaufelberger wrote 04/02/24, 15:03
Removed cc Simon Schaufelberger. -
Marcin Sągol uploaded patch set 8
V +104/09/24, 08:41 -
Marcin Sągol commented on patch set 8 04/09/24, 08:44
select-check-box-filter.ts:23ReplyI have created first draft of the component.select-check-box-element.ts:98ReplyDoneSelectCheckBoxElement.php:83ReplyI followed the suggestion 'hideSuggest' => true setting, which wasn't inside the `appearance` group.Feature-103515-AddAnOptionToRenderFilterAboveSelectCheckBoxFieldType.rst:14ReplyDoneFeature-103515-AddAnOptionToRenderFilterAboveSelectCheckBoxFieldType.rst:45ReplyDone -
core-ci voted on patch set 8 V +1 04/09/24, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55592
-
Andreas Kienast commented on patch set 8 04/09/24, 09:27
alert.ts:20We should limit this to the same capabilities as in `@typo3/backend/notification`. You may make use of `SeverityEnum.notice`.select-check-box-filter.ts:29IMO this is redundant to the `alert` property.select-check-box-filter.ts:68This looks superfluous, `typo3-backend-alert` is already registered in `HTMLElementTagNameMap` to be an Alert element. -
Marcin Sągol uploaded patch set 9
V +106/24/24, 13:36 -
core-ci voted on patch set 9 V +1 06/24/24, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60176
-
Marcin Sągol rebased onto patch set 10
V +106/30/24, 10:50 -
Marcin Sągol uploaded patch set 11 06/30/24, 10:55
-
core-ci voted on patch set 10 V -1 06/30/24, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60664
-
core-ci voted on patch set 11 V +1 06/30/24, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60665
-
Marcin Sągol uploaded patch set 12
V +106/30/24, 11:40 -
Marcin Sągol commented on patch set 10 06/30/24, 11:42
be_groups.php:125ReplyI am not sure if this is a good idea. If some list is very short, the filter field might not make sens. Wouldn't it be better to leave the decision to developers if they want to enable this filter or not?Feature-103515-AddAnOptionToRenderFilterAboveSelectCheckBoxFieldType.rst:17ReplyDone -
Marcin Sągol commented on patch set 12 06/30/24, 11:44
alert-element.ts:1To be able to finish this task (make it complete) i had to use the new Alert component, which was introduces as a separate feature patch here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84535 -
Marcin Sągol commented on patch set 12 06/30/24, 11:46
alert.ts:20ReplyDoneselect-check-box-filter.ts:68ReplyDone -
core-ci voted on patch set 12 V +1 06/30/24, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60669
-
Georg Ringer commented on patch set 12 CR -1 V +1 07/04/24, 19:52
be_groups.php:125ReplyIMO we should have it true by default as this is best for the editors. if it is not useful, the developer can decide to disable it - otherwise the setting would be mostly forgottenFeature-103515-AddAnOptionToRenderFilterAboveSelectCheckBoxFieldType.rst:1please change to 13.3 -
Garvin Hicking commented on patch set 12 07/04/24, 20:20
Reply
as mentioned by Georg, I agree a on having it as a default and opt-out. Resolving this in favor of georgs comment.be_groups.php:125ReplyI agree. are there core fields where we should disable it? -
Marcin Sągol uploaded patch set 13
CR -1V +107/05/24, 08:44 -
Marcin Sągol commented on patch set 13 07/05/24, 08:47
be_groups.php:125ReplyI think not, for those packages that I have installed, it is used mainly in `be_groups` and `be_users` and for one field in the `sys_workspaces`.Feature-103515-AddAnOptionToRenderFilterAboveSelectCheckBoxFieldType.rst:1ReplyDone -
core-ci voted on patch set 13 V +1 07/05/24, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61023
-
Oli Bartsch uploaded patch set 14
V +107/05/24, 08:59 -
Oli Bartsch commented on patch set 14 07/05/24, 09:00
select-check-box-filter.ts:63Let's show the icon here. Additionally, this should be "info"select-check-box-filter.ts:94we can use toggle hereselect-check-box-element.ts:16Lets add the module in the element since this component is not directly using it. -
Oli Bartsch commented on patch set 14 07/05/24, 09:00
select-check-box-filter.ts:29ReplyDoneselect-check-box-filter.ts:63ReplyDoneselect-check-box-filter.ts:94ReplyDoneselect-check-box-element.ts:16ReplyDoneSelectCheckBoxElement.php:83ReplyAcknowledged -
Oli Bartsch uploaded patch set 15 07/05/24, 09:02
-
Oli Bartsch commented on patch set 15 07/05/24, 09:03
I really like this feature. Can we please get the alert component in as separat patch? @a.fernandez@scripting-base.de -
core-ci voted on patch set 14 V +1 07/05/24, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61024
-
core-ci voted on patch set 15 V +1 07/05/24, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61026
-
Marcin Sągol voted on patch set 15 CR +1 V +1 07/05/24, 09:12
-
Oli Bartsch commented on patch set 15 CR -1 07/05/24, 09:54
Reply
-1 until the alert element is merged. -
Marcin Sągol commented on patch set 15 07/05/24, 10:53
Reply
The patch with Alert component only: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84535 -
Oli Bartsch uploaded patch set 16
CR +1V +107/05/24, 13:59 -
core-ci voted on patch set 16 V +1 07/05/24, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61058
-
Oli Bartsch uploaded patch set 17
V +107/10/24, 07:55 -
Oli Bartsch commented on patch set 17 CR +1 V +1 07/10/24, 07:55
Reply
Donealert-element.ts:1ReplyDone -
core-ci voted on patch set 17 V +1 07/10/24, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61290
-
Georg Ringer voted on patch set 17 CR +1 V +1 07/10/24, 08:01
-
Andreas Kienast commented on patch set 17 CR -2 07/10/24, 08:06
Reviewing -
Benjamin Franzke commented on patch set 17 CR -1 07/10/24, 08:15
select-check-box-filter.ts:56The alert should be rendered based on *state* (that is properties) in `render()` and not injected as a side-effect to some "other" place in the DOM.select-check-box-filter.ts:68The entire filter mechanism suboptimal, as we simply "modify" markup that does not belong to this component. A filter mechanism should render based on state and the list of options would need to be *rendered* by the *filtering* component.SelectCheckBoxElement.php:162Webcomponents do not support self-closing tags -
Marcin Sągol uploaded patch set 18
CR +1V +107/10/24, 08:47Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
-
core-ci voted on patch set 18 V +1 07/10/24, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61299
-
Marcin Sągol uploaded patch set 19
V +107/10/24, 09:50Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Marcin Sągol commented on patch set 19 07/10/24, 09:52
select-check-box-filter.ts:56ReplyPlease check now.select-check-box-filter.ts:68ReplyIt would be great if someone more experienced could refactor it, I am not sure how it should be done properly.SelectCheckBoxElement.php:162ReplyDone -
core-ci voted on patch set 19 V +1 07/10/24, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61304
-
Oskar Dydo uploaded patch set 20
V +109/04/24, 12:21Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 20 V +1 09/04/24, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64752
-
Oskar Dydo commented on patch set 20 09/04/24, 22:09
select-check-box-filter.ts:56Reply Unresolved@ben@bnf.dev Could you please verify if the previous changes met your expectations?select-check-box-filter.ts:68Reply Unresolved@ben@bnf.dev Do you have any updates on this? -
Oskar Dydo uploaded patch set 21
V +109/06/24, 08:27Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 21 V +1 09/06/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64917
-
Guido Schmechel commented on patch set 21 V +1 09/07/24, 16:16
Nice feature! Worked very well. -
Andreas Kienast voted on patch set 21 CR 0 09/07/24, 20:08
-
Garvin Hicking commented on patch set 22
V +109/07/24, 20:23Published edit on patch set 21. -
core-ci voted on patch set 22 V +1 09/07/24, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65026
-
Garvin Hicking commented on patch set 22 V +1 09/07/24, 20:34
Works for me, however sadly can't code-review the JS. -
Markus Klein commented on patch set 22 09/13/24, 10:50
Feature-103515-AddAnOptionToRenderFilterAboveSelectCheckBoxFieldType.rst:6Unresolvedadded an option docs are past tense -
Markus Klein commented on patch set 23
V +109/13/24, 10:51Published edit on patch set 22. -
core-ci voted on patch set 23 V +1 09/13/24, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65664
-
Guido Schmechel voted on patch set 23 V +1 09/13/24, 14:51
-
Garvin Hicking voted on patch set 23 V +1 09/14/24, 11:18
-
Benni Mack commented on patch set 23 03/21/25, 14:59
whats the status here? -
Tymoteusz Motylewski commented on patch set 23 03/24/25, 19:21
Reply Unresolved
AFAIK - the change worked as expected, however as Benjamin commented, the solution was suboptimal - the authors (Marcin and Oskar) asked for guidance but didn't get it Next steps: - get guidance from the core team how this should be implemented properly - rebase and adapt the patch according to the guidance -
Benni Mack marked it work in progress 04/21/26, 14:56
-
Benni Mack wrote 04/21/26, 14:56
Removed cc Benni Mack. -
Marcin Sągol uploaded patch set 24
V +108/07/26, 19:37 -
core-ci voted on patch set 24 V +1 08/07/26, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106138