83638[FEATURE] Group-based content fetching in Frontend
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+1 −0
- typo3/sysext/core/Documentation/Changelog/13.2/Feature-103894-AdditionalPropertiesForColumnsInPageLayouts.rstnew+101 −0
- typo3/sysext/frontend/Classes/Content/ContentSlideMode.phpnew+36 −0
- typo3/sysext/frontend/Classes/Content/RecordCollector.php3new+83 −0
- typo3/sysext/frontend/Classes/DataProcessing/PageContentFetchingProcessor.php3new+73 −0
- typo3/sysext/frontend/Configuration/Services.yaml+4 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/Fixtures/PageContentProcessor/Pages/Default.htmlnew+26 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/Fixtures/PageContentProcessor/Pages/Home.htmlnew+16 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/Fixtures/PageContentProcessor/Pages/Productdetail.htmlnew+26 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/Fixtures/PageContentProcessor/Partials/SingleContent.htmlnew+6 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/Fixtures/PageContentProcessor/setup.typoscriptnew+6 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/Fixtures/RecordTransform/setup.typoscriptrenamed+0 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/PageContentFetchingProcessorTest.phpnew+94 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/RecordTransformationProcessorTest.php+1 −1
Review log 3451
Show 1826 earlier messages
-
Benni Mack uploaded patch set 1 04/02/24, 12:26
-
core-ci voted on patch set 1 V -1 04/02/24, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55163
-
Nikita Hovratov commented on patch set 1 04/02/24, 19:13
-
Benni Mack commented on patch set 1 04/02/24, 19:36
RecordFactory.php:139Replyyes, I thought about adding TcaSchema first, but this has / had too many open questions for me and too much code to get started. I'd rather remove it later-on from this place, and replace it with TcaSchema. In addition, I think we should have a RecordInterface, and having a "RawRecord" with just the raw properties, then a Record object (which decorates the RawRecord) and then we can have a ResolvedRecord - wdyt? This way, we can add the RelationResolver in a separate / followup patch. Some further remarks from Benji today: - get rid of the wither method - remove the ContentFetchingProcessor - consider a better name for the PageContentFetchingProcessor - add tests for slide mode Further notes from me: Use lower-cased full type "content.textpic". where the "content" part would come from a TCA[tt_content][ctrl][blockType] = "content", and the rest from the type field. -
Nikita Hovratov commented on patch set 1 04/02/24, 19:56
RecordFactory.php:139ReplyOk, we can later streamline this. Content Blocks will need the same treatment. I like the idea of decorated raw records, in fact this is exactly what I am doing in Content Blocks. It will be later necessary to have nested "ResolvedRecords/ResolvedRelations". So the `properties" or maybe later `resolvedProperties` can have one or an array of "ResolvedRecords" themselves. We need to think about this well, before making it public API. I would suggest to make it internal (RecordFactory) until we have figured all things out. > Use lower-cased full type "content.textpic". where the "content" part would come > from a TCA[tt_content][ctrl][blockType] = "content", and the rest from the type field. So this should be like a unique identifier for the record type? This would need validation somehow, so no two TCA definitions have the same `blockType`. The table name is unique, though. Maybe we should just use it instead? -
Oliver Hader commented on patch set 1 04/03/24, 09:38
Record.php:96Comparing this with other frameworks like Polymer or VueJS, I think it would be good to explicitly separate (user-submitted) properties from internal/computed data, thus e.g. * `props` for the current `properties` * `data` or `meta` for anything that is generated or context specific This would resolve ambiguity for those special names - and e.g. allowing to use `language` as property in the `Record` concept.Record.php:113Pattern type of this class? immutable like done in `withRawProperties()` or mutable for array-access → alternatively deny `offsetSet` und `offsetUnset` but use dedicated `withPropertyValue(string $name, mixed $value): self` and `withUnsetProperty(string $name): selfRecordFactory.php:25`@internal` probably for the time beingRecordFactory.php:139ReplyFor security concerns it lacks somehow the context the record is supposed to be used/published - for instance, `be_users.password` should not accidentally be exposed to the frontend. But okay to refine that later... -
Benni Mack uploaded patch set 2
V -104/03/24, 10:19 -
core-ci voted on patch set 2 V -1 04/03/24, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55260
-
Benni Mack uploaded patch set 3
V -104/08/24, 13:42 -
core-ci voted on patch set 3 V -1 04/08/24, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55565
-
Benni Mack uploaded patch set 4
V -104/08/24, 14:57 -
core-ci voted on patch set 4 V -1 04/08/24, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55570
-
Benni Mack uploaded patch set 5
V -104/09/24, 11:38 -
Benni Mack commented on patch set 5 04/09/24, 11:38
Record.php:113ReplyDoneRecordFactory.php:25ReplyDone -
Christian Kuhn commented on patch set 5 04/09/24, 11:42
RecordCollector.php:58does this collide with the strategy to resolve relations at a central point exactly once using refindex? -
core-ci voted on patch set 5 V -1 04/09/24, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55600
-
Benni Mack commented on patch set 5 04/09/24, 14:39
RecordCollector.php:58ReplyI do have this in mind / in the back of my head. Right now, this is all properly encapsulated in internal structure, so it does not really matter how we resolve this later-on (e.g. switching to one DB query), however we would need to consider how to deal with the different slide options available (maybe fetch all of them once, order by colPos and pid and then group them in PHP then). Doing this in the code could be even possible right now, I can try to do this right away. -
Benni Mack uploaded patch set 6
V -104/09/24, 17:24 -
Benni Mack uploaded patch set 7 04/09/24, 17:25
-
core-ci voted on patch set 7 V -1 04/09/24, 17:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55624
-
core-ci voted on patch set 6 V -1 04/09/24, 17:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55622
-
André Buchmann commented on patch set 7 04/10/24, 17:57
References (Files, Inline Elements,...) should be resolved recursively -
Nikita Hovratov commented on patch set 7 04/13/24, 12:25
Reply
The (recursive) resolving will be continued in this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83725 -
Benni Mack uploaded patch set 8
V -105/14/24, 18:55 -
core-ci voted on patch set 8 V -1 05/14/24, 18:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57726
-
Benni Mack uploaded patch set 9
V -105/14/24, 19:07
-
core-ci voted on patch set 9 V -1 05/14/24, 19:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57727
-
André Buchmann commented on patch set 9 05/17/24, 05:59
PageContentFetchingProcessor.php:57There is no identifier in the BackendLayoutView::getDefaultColumnLayout() configuration. Therefor forcing the integrator to create a BackendLayout and assign it to the pages. -
André Buchmann uploaded patch set 10
V -105/17/24, 08:05 -
core-ci voted on patch set 10 V -1 05/17/24, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57855
-
André Buchmann uploaded patch set 11
V -105/17/24, 11:45 -
core-ci voted on patch set 11 V -1 05/17/24, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57864
-
Benni Mack commented on patch set 11 05/17/24, 15:03
PageContentFetchingProcessor.php:57ReplyI think it'd be good to add them there.PageContentFetchingProcessor.php:57ReplyI think it'd be good to add them there. -
Benni Mack uploaded patch set 12
V -105/23/24, 21:45 -
Benni Mack commented on patch set 12 05/23/24, 21:47
Record.php:96ReplyDone -
core-ci voted on patch set 12 V -1 05/23/24, 21:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58113
-
Benni Mack uploaded patch set 13
V -105/23/24, 22:25 -
core-ci voted on patch set 13 V -1 05/23/24, 22:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58114
-
Benni Mack uploaded patch set 14
V -105/23/24, 22:36 -
core-ci voted on patch set 14 V +1 05/23/24, 22:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58115
-
Benni Mack uploaded patch set 15
V +105/24/24, 10:15 -
Benni Mack commented on patch set 15 05/24/24, 10:16
RecordCollector.php:58ReplyI left out the relations for the time being -
Benni Mack updated the commit message in patch set 16 05/24/24, 10:17
-
core-ci voted on patch set 16 V -1 05/24/24, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58147
-
core-ci voted on patch set 15 V +1 05/24/24, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58146
-
Georg Ringer commented on patch set 17
V -105/24/24, 10:29Published edit on patch set 16. -
Georg Ringer voted on patch set 17 CR +1 V +1 05/24/24, 10:31
-
core-ci voted on patch set 17 V +1 05/24/24, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58148
-
Oli Bartsch voted on patch set 17 CR +1 V +1 05/24/24, 11:52
-
Benni Mack commented on patch set 17 CR +2 V +2 05/24/24, 12:14
Thanks for the votes! -
Benni Mack merged patch set 18 05/24/24, 12:14
RecordFactory.php:139