Review main Merged

83642[FEATURE] Add keyboard shortcut in FormEngine for Save & Close

Andreas Kienast CR +2 V +2 Easy +43 −5 updated 04/04/24, 07:21

Commit message

A new hotkey is introduced in the FormEngine scope that lets editors
invoke "Save and Close" via `Ctrl/Cmd+Shift+S`.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1115

  1. Andreas Kienast uploaded patch set 1 04/03/24, 07:44

  2. core-ci voted on patch set 1 V +1 04/03/24, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55206

  3. Andreas Kienast uploaded patch set 2 V +1 04/03/24, 14:29

  4. Andreas Kienast updated the commit message in patch set 3 04/03/24, 14:32

  5. core-ci voted on patch set 2 V +1 04/03/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55270

  6. core-ci voted on patch set 3 V +1 04/03/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55271

  7. Garvin Hicking uploaded patch set 4 V +1 04/03/24, 15:59

    Docs
  8. Garvin Hicking commented on patch set 4 CR +1 V +1 04/03/24, 16:00

    This feels like crafted for me specifically ;-) Saves good to me. Unified the upper/lowercasing and fixed a minor spelling mistake during testing.
  9. core-ci voted on patch set 4 V +1 04/03/24, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55273

  10. Simon Schaufelberger commented on patch set 4 04/03/24, 23:15

    Feature-103529-IntroduceHotkeyForSaveAndClose.rst:15

    lowercase s at the end

    Feature-103529-IntroduceHotkeyForSaveAndClose.rst:22

    lowercase s at the end. should match line 21 😊
  11. Andreas Kienast commented on patch set 4 04/04/24, 05:45

    Feature-103529-IntroduceHotkeyForSaveAndClose.rst:15 Reply

    I took the "inspiration" for the uppercase "S" from any other system. macOS, Windows and also several Linux desktops use uppercase letters.

    Feature-103529-IntroduceHotkeyForSaveAndClose.rst:22 Reply

    Done
  12. Garvin Hicking commented on patch set 4 04/04/24, 06:29

    Feature-103529-IntroduceHotkeyForSaveAndClose.rst:22 Reply

    I actually changed that to a lowecase in that one instance by intent, because otherwise people might accidentally use Shift to get the uppercase S. IMo that makes it clearer.
  13. Oli Bartsch voted on patch set 4 CR +1 V +1 04/04/24, 07:04

  14. Andreas Kienast voted on patch set 4 CR +2 V +2 04/04/24, 07:21

  15. Andreas Kienast merged patch set 5 04/04/24, 07:21