83642[FEATURE] Add keyboard shortcut in FormEngine for Save & Close
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Garvin Hicking +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1115
-
Andreas Kienast uploaded patch set 1 04/03/24, 07:44
-
core-ci voted on patch set 1 V +1 04/03/24, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55206
-
Andreas Kienast uploaded patch set 2
V +104/03/24, 14:29 -
Andreas Kienast updated the commit message in patch set 3 04/03/24, 14:32
-
core-ci voted on patch set 2 V +1 04/03/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55270
-
core-ci voted on patch set 3 V +1 04/03/24, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55271
-
Garvin Hicking uploaded patch set 4
V +104/03/24, 15:59Docs -
Garvin Hicking commented on patch set 4 CR +1 V +1 04/03/24, 16:00
This feels like crafted for me specifically ;-) Saves good to me. Unified the upper/lowercasing and fixed a minor spelling mistake during testing. -
core-ci voted on patch set 4 V +1 04/03/24, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55273
-
Simon Schaufelberger commented on patch set 4 04/03/24, 23:15
Feature-103529-IntroduceHotkeyForSaveAndClose.rst:15lowercase s at the endFeature-103529-IntroduceHotkeyForSaveAndClose.rst:22lowercase s at the end. should match line 21 😊 -
Andreas Kienast commented on patch set 4 04/04/24, 05:45
Feature-103529-IntroduceHotkeyForSaveAndClose.rst:15ReplyI took the "inspiration" for the uppercase "S" from any other system. macOS, Windows and also several Linux desktops use uppercase letters.Feature-103529-IntroduceHotkeyForSaveAndClose.rst:22ReplyDone -
Garvin Hicking commented on patch set 4 04/04/24, 06:29
Feature-103529-IntroduceHotkeyForSaveAndClose.rst:22ReplyI actually changed that to a lowecase in that one instance by intent, because otherwise people might accidentally use Shift to get the uppercase S. IMo that makes it clearer. -
Oli Bartsch voted on patch set 4 CR +1 V +1 04/04/24, 07:04
-
Andreas Kienast voted on patch set 4 CR +2 V +2 04/04/24, 07:21
-
Andreas Kienast merged patch set 5 04/04/24, 07:21