Review main Merged

83643[TASK] Deprecate `@typo3/backend/document-save-actions`

Andreas Kienast CR +2 V +2 Normal +189 −9 updated 04/05/24, 14:26

Commit message

The JavaScript module `@typo3/backend/document-save-actions` was
introduced in TYPO3 v7 to add some interactivity in FormEngine context.
At first it was only used to disable the submit button and render a
spinner icon instead. Over the course of some years, the module got more
functionality.

After some refactorings within FormEngine, the module became rather a
burden. This became visible with the introduction of the Hotkeys API, as
the `@typo3/backend/document-save-actions` module reacts on explicit
`click` events on the save icon, that is not triggered when FormEngine
invokes a save action via keyboard shortcuts.

Adjusting `document-save-actions`'s behavior is necessary here, but
would become a breaking change, which is unacceptable after the 13.0
release. For this reason, said module has been marked as deprecated and
its usages are replaced by its successor
`@typo3/backend/form/submit-interceptor`.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9