Review main Merged

83644[BUGFIX] Fix wrong GUI crop area placement on edge cases

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 04/04/24, 12:28

Commit message

In the image editor, the "Cropped area" was configured with a `ceil`ed
width and height. Since all other dimensions are `floor`ed, this might
cause an overlap.
Due to the configured cropping mode, defining that the cropping area
must never exceed the image dimensions, the cropper library places the
cropper to a position that's mathematically correct but not desired.

To solve this issue, the `width` and `height` properties fed to the
cropper are now `floor`ed as well, basically aligning with the rest of
the coordinates.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Kevin Appelt +1
    • Garvin Hicking +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Kevin Appelt +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Andreas Kienast uploaded patch set 1 04/04/24, 07:18

  2. Oli Bartsch voted on patch set 1 CR +1 04/04/24, 07:21

  3. core-ci voted on patch set 1 V +1 04/04/24, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55321

  4. Kevin Appelt voted on patch set 1 CR +1 V +1 04/04/24, 07:29

  5. Andreas Kienast updated the commit message in patch set 2 CR +1 V +1 04/04/24, 07:41

  6. Kevin Appelt voted on patch set 2 CR +1 V +1 04/04/24, 07:43

  7. core-ci voted on patch set 2 V +1 04/04/24, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55324

  8. Jörg Bösche voted on patch set 2 CR +1 04/04/24, 08:14

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 04/04/24, 11:26

  10. Andreas Kienast voted on patch set 2 CR +2 V +2 04/04/24, 11:53

  11. Andreas Kienast merged patch set 3 04/04/24, 12:28