83648[BUGFIX] Prevent rendering FlexForm diff of deleted records in history
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
- Christian Weiske +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1720
-
Christoph Lehmann uploaded patch set 1 04/04/24, 13:44
-
Oliver Klee commented on patch set 1 CR +1 04/04/24, 13:48
11.5 is not affected? -
Oliver Klee commented on patch set 1 CR 0 04/04/24, 13:49
And could we cover this with a (functional) test? -
core-ci voted on patch set 1 V -1 04/04/24, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55336
-
Christoph Lehmann commented on patch set 1 04/04/24, 13:54
Reply
The class was added in 12.4 (#91148) -
Oliver Klee commented on patch set 1 04/04/24, 14:13
Reply
Thanks, ack. -
Christoph Lehmann marked it work in progress 04/09/24, 07:27
-
Christian Weiske commented on patch set 1 V +1 04/24/24, 10:48
With this patch the record history view works again here. -
Daniel Schultheis voted on patch set 1 V +1 06/05/24, 08:17
-
Christoph Lehmann rebased onto patch set 2
V +106/05/24, 20:04 -
core-ci voted on patch set 2 V -1 06/05/24, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58764
-
Georg Ringer uploaded patch set 3
V -106/05/24, 20:44 -
core-ci voted on patch set 3 V +1 06/05/24, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58765
-
Georg Ringer commented on patch set 3 CR +1 V +1 06/05/24, 21:37
This change is ready for review. -
Oliver Klee voted on patch set 3 V +1 06/06/24, 07:41
-
Oliver Klee voted on patch set 3 CR +1 06/06/24, 07:42
-
Nikita Hovratov voted on patch set 3 CR +1 06/06/24, 07:46
-
Christian Weiske voted on patch set 3 V +1 06/12/24, 13:33
-
Benni Mack commented on patch set 3 CR +2 V +2 06/13/24, 17:42
FlexFormValueFormatter.php:49I would usually recommend using $record === null, but fine with it. -
Benni Mack merged patch set 4 06/13/24, 17:42