Review main Abandoned

83650[BUGFIX] Ensure correct position of CEs on drag-n-drop

Ayke Halder CR 0 V 0 Easy +1 −7 updated 03/11/25, 10:36

Commit message

In page module content elements can be moved by drag-n-drop. When a CE
is moved by drag-n-drop from inside a container element the position
must be relative to the page and not to the container element.

Container elements are provided by non-core extensions.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 912

  1. Ayke Halder uploaded patch set 1 04/04/24, 21:15

  2. core-ci voted on patch set 1 V +1 04/04/24, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55344

  3. Christian Rath-Ulrich voted on patch set 1 CR +1 V +1 07/17/24, 15:31

  4. Benjamin Kott commented on patch set 1 CR -2 07/18/24, 07:02

    this is not a bugfix, as a bugfix would describe that the core itself has a problem. this problem seems to be introduced by a third-party extension that needs to adapt to the core functions and not the other way around. i am not saying that we cannot optimize the behaviour here to make it easier for third-party extensions. but it´s not a bugfix and will not be applied to 12.4
  5. Ayke Halder commented on patch set 1 07/18/24, 07:57

    Is this a feature instead?

    Reply

  6. Benjamin Kott commented on patch set 1 07/18/24, 08:30

    Reply Unresolved

    it´s nothing broken from core side so it cannot be a bugfix. everything is working as expected. we can optimize the code as a task - but it will only make it to v13.
  7. Benni Mack updated the commit message in patch set 2 CR +1 V +1 10/18/24, 13:38

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  8. core-ci voted on patch set 2 V -1 10/18/24, 22:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68015

  9. Simon Schaufelberger rebased onto patch set 3 V -1 10/21/24, 10:44

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  10. core-ci voted on patch set 3 V +1 10/21/24, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68295

  11. Benjamin Kott commented on patch set 3 CR -2 03/11/25, 10:36

  12. Benjamin Kott abandoned the change 03/11/25, 10:36