83651[BUGFIX] Type cast PageView return value to string
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1011
-
Oli Bartsch uploaded patch set 1 04/05/24, 06:53
-
core-ci voted on patch set 1 V +1 04/05/24, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55369
-
Oliver Klee voted on patch set 1 CR +1 V +1 04/05/24, 07:47
-
Oliver Klee commented on patch set 1 V 0 04/05/24, 07:47
Could we cover this case with a functional test? -
Oli Bartsch commented on patch set 1 04/05/24, 08:05
Reply
What would you like to test? That the type cast is applied? -
Oliver Klee commented on patch set 1 04/05/24, 08:42
Reply
Yes, indirectly: If the rendered view is null, test that `PageViewContentObject::render` returns an empty string. -
Oliver Klee commented on patch set 1 04/05/24, 08:43
… which probably would be a unit test. In addition, we can have a functional test that checks that an empty template file renders as an empty string. -
Andreas Kienast commented on patch set 1 04/05/24, 12:22
IMO this could/should be fixed in upstream Fluid additionally. `AbstractTemplateView::render()` is annotated to return a `string`, but it's not explicitly defined via a return type declaration. -
Stefan Bürk commented on patch set 1 CR +1 V +1 04/07/24, 16:10
Reply
IMO `AbstractTemplateView` needs to be considered public API, and adding a return type (string) would be breaking (for a minor version release). Granted, a string cast may be added, but did not ensure it at this point here anyway without the return type (and than additional for the viewinterface). If I'm not fully wrong we already discussed to move that breaking for a fluid major, but delayed branching/cooping on a major in fluid for now. So having a type-cast as a fix until we can deal with it in lower parts is fine for me. -
Andreas Kienast voted on patch set 1 CR +2 V +2 04/07/24, 16:12
-
Andreas Kienast merged patch set 2 04/07/24, 16:12