83673[FEATURE] Change button behaviour in page module to improve UX
Commit message
Review
-
Code review CR -1
- Christian Rath-Ulrich -1
- Andreas Kienast -1
- Benjamin Kott -1
-
Verified V 0
- core-ci +1 CI
Issues 2
Files 4
Review log 1113
-
Ayke Halder uploaded patch set 1 04/05/24, 15:52
-
core-ci voted on patch set 1 V +1 04/05/24, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55394
-
Simon Schaufelberger commented on patch set 1 04/05/24, 19:06
I dislike small buttons as you need to be more precise with your mouse movement. Bigger buttons are better to move your mouse to -> better UX. -
Ayke Halder commented on patch set 1 04/05/24, 19:58
Reply
The size of action-buttons is not changed. For the 'add content' button the height is not changed, but the width is reduced as text-node 'Content' is removed. The 'add content' button has a size of 34px x 26px with clear space around. Shell we upsize the 'click-target/'touch-target' to a full 48px x 48px by making the button clickable beyond its visual bounds? E.g. further reading: https://support.google.com/accessibility/android/answer/7101858?hl=en -
Ayke Halder updated the commit message in patch set 2
V +104/05/24, 20:40 -
Ayke Halder commented on patch set 2 04/05/24, 20:45
Reply
The intention here is to improve the UX of the page module as a whole. I changed the commit message to make this clear. This neither improves nor should impair the UX of the buttons itselves in any way. -
core-ci voted on patch set 2 V +1 04/05/24, 20:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55399
-
Stefan Bürk commented on patch set 2 04/08/24, 15:50
Unresolved
I really dislike this. This may improve it for some people, and for a lot of other people it decrease the UX. It also removes the "direct" visibilty which action is possible for each content element WITHOUT having to hover over each item itself. Beside that, I'd really love to see a statement on that topic from the Accebillity Team or People being experienced in this topic as well. From a personal point of view and knowing a lot of editors this is not an improvement and making it worser. I'd also argue, that the action on elements (managing the elements) is an important and direct action point in the Page Layout module - and the `preview` / content rendering more a second priority. We had instances where we reduced the "preview" data a lot, in other strippeed down to "essential" stuff - and others where only a "special" description field not used in the frontend is used to be displayed as PageLayout content information. In all cases, direct action is and will be the first citizen in this work. And I don't really get the point why "new" place markers should be "emphasizued" over managing already existing content. Neither workload has precedeence in general over the other. TBH - not checked out this patch - only reading the commit message and the screen shot in the issues. -
Andreas Kienast commented on patch set 2 CR -1 04/08/24, 16:46
Unresolved
I understand the need to show the actions buttons on hover only. However, this has changed a few major versions ago as it actually decreased UX. Let's get the opinion of the UX team for this. -
Christian Rath-Ulrich commented on patch set 2 07/17/24, 15:06
During the codesprint in Düsseldorf, we concluded that it is better to label more explicitly rather than less, in order to facilitate access for people with cognitive impairments. Therefore, the label here was changed from '+ content' to '+ Create new content'. This would be a step backwards. -
Christian Rath-Ulrich voted on patch set 2 CR -1 07/17/24, 15:07
-
Benjamin Kott commented on patch set 2 CR -1 07/18/24, 05:21
i second the previous reviewers, this is a step back. this patch makes the system harder to use even for seeing people. -
Garvin Hicking abandoned the change 02/19/26, 21:31
There has not been activity on this anymore and the votes indicate this is not going into a direction. Hope it's fine to abandon this now.