Review main Merged

83675[BUGFIX] Prevent indexed_search crash in BE

Christian Kuhn CR +2 V +2 Easy +7 −7 updated 04/07/24, 05:51

Commit message

'phash' has been changed from an int to a string
with #102975. This leads to a BE crash when selecting
details of an indexed page.

Make argument 'pageHash' a string instead of an int
within the extbase based BE module controller
statisticDetailsAction() to enable proper extbase
mapping of that argument. Also make this argument
non-optional and deal with the value as string in
the queries.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 04/06/24, 13:07

  2. Christian Kuhn updated the commit message in patch set 2 04/06/24, 13:11

  3. core-ci voted on patch set 1 V +1 04/06/24, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55436

  4. core-ci voted on patch set 2 V +1 04/06/24, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55437

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 04/06/24, 15:38

  6. Stefan Bürk commented on patch set 2 CR +1 V +1 04/06/24, 20:03

    :/ thanks lolli
  7. Oliver Klee voted on patch set 2 CR +1 04/06/24, 20:34

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 04/07/24, 05:51

  9. Christian Kuhn merged patch set 3 04/07/24, 05:51