Review main Merged

83676[BUGFIX] Deal with nullable pages['keywords'] field in IS

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 04/07/24, 05:46

Commit message

The BE may crash when adding a 'keyword' to a page record
using the indexed_search BE module: Field 'keywords' of
table 'pages' may be null, the call to GU::trimExplode()
has to be sanitized for this case since #101453.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 910

  1. Christian Kuhn uploaded patch set 1 04/06/24, 13:39

  2. Christian Kuhn commented on patch set 1 04/06/24, 13:40

    Note https://review.typo3.org/c/Packages/TYPO3.CMS/+/83675 needs to be applied to reach this point in main.
  3. core-ci voted on patch set 1 V +1 04/06/24, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55438

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 04/06/24, 15:38

  5. Oliver Klee voted on patch set 1 CR +1 04/06/24, 18:28

  6. Oliver Klee voted on patch set 1 V +1 04/06/24, 18:28

  7. Benni Mack voted on patch set 1 CR +1 V +1 04/06/24, 19:44

  8. Stefan Bürk voted on patch set 1 CR +1 V +1 04/06/24, 19:57

  9. Christian Kuhn voted on patch set 1 CR +2 V +2 04/07/24, 05:45

  10. Christian Kuhn merged patch set 2 04/07/24, 05:46