83676[BUGFIX] Deal with nullable pages['keywords'] field in IS
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Garvin Hicking +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Garvin Hicking +1
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
- Bug #103542indexed_search AdministrationRepository: GeneralUtility::trimExplode(): Argument #2 ($string) must be of type string, null given
- Task #101453Add native type declarations to GU array methods
- Bug #103541Validation failed while trying to call TYPO3\CMS\IndexedSearch\Controller\AdministrationController->statisticDetailsAction().
Files 1
Review log 910
-
Christian Kuhn uploaded patch set 1 04/06/24, 13:39
-
Christian Kuhn commented on patch set 1 04/06/24, 13:40
Note https://review.typo3.org/c/Packages/TYPO3.CMS/+/83675 needs to be applied to reach this point in main. -
core-ci voted on patch set 1 V +1 04/06/24, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55438
-
Garvin Hicking voted on patch set 1 CR +1 V +1 04/06/24, 15:38
-
Oliver Klee voted on patch set 1 CR +1 04/06/24, 18:28
-
Oliver Klee voted on patch set 1 V +1 04/06/24, 18:28
-
Benni Mack voted on patch set 1 CR +1 V +1 04/06/24, 19:44
-
Stefan Bürk voted on patch set 1 CR +1 V +1 04/06/24, 19:57
-
Christian Kuhn voted on patch set 1 CR +2 V +2 04/07/24, 05:45
-
Christian Kuhn merged patch set 2 04/07/24, 05:46