Review main Merged

83677[BUGFIX] Prevent crashes setting stopwords in IS BE module

Christian Kuhn CR +2 V +2 Easy +12 −18 updated 04/08/24, 06:54

Commit message

Argument $pageId is mandatory in saveStopwordsKeywordsAction()
since #102914. The link to that action is created in a fluid
section three times: Once with a proper pages uid, twice without.

This leads to crashes when trying to "Save stopwords" in the
indexed_search BE "detail" module in sections "Words by top count"
and "Words by frequency".

The patch adds the pages-uid argument for these two sections and
simplifies the fluid template a bit along the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 810

  1. Christian Kuhn uploaded patch set 1 04/06/24, 14:05

  2. Christian Kuhn commented on patch set 1 04/06/24, 14:05

    Note https://review.typo3.org/c/Packages/TYPO3.CMS/+/83675 needs to be applied to reach this point in main.
  3. core-ci voted on patch set 1 V +1 04/06/24, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55439

  4. Christian Kuhn commented on patch set 1 CR -1 04/07/24, 05:53

    mixes a different fix into it.
  5. Christian Kuhn uploaded patch set 2 CR -1 V +1 04/07/24, 06:44

  6. core-ci voted on patch set 2 V +1 04/07/24, 06:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55493

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 04/07/24, 12:38

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 04/08/24, 06:48

  9. Christian Kuhn voted on patch set 2 CR +2 V +2 04/08/24, 06:54

  10. Christian Kuhn merged patch set 3 04/08/24, 06:54